You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/09 13:55:56 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24342: chore: remove deprecated api /superset/tables//...
dpgaspar opened a new pull request, #24342:
URL: https://github.com/apache/superset/pull/24342
### SUMMARY
Removes old deprecated API `/superset/tables/<int:db_id>/...` use `/api/v1/database/<int:pk>/tables/` instead
Effort on removing deprecated APIs from `/superset`: https://github.com/apache/superset/discussions/24332
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24342:
URL: https://github.com/apache/superset/pull/24342#discussion_r1224625919
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...`
Review Comment:
I think is just a form of separating things you should really be careful when upgrading from things you might find useful or interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24342:
URL: https://github.com/apache/superset/pull/24342#discussion_r1224596304
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...`
Review Comment:
Could you move this to the breaking changes section and add the PR number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24342:
URL: https://github.com/apache/superset/pull/24342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #24342:
URL: https://github.com/apache/superset/pull/24342#discussion_r1224620780
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...`
Review Comment:
this is strange I think we used to only have `Next` and potential downtime, since all that lands on `Next` would somewhat be a minor breaking change. What's the difference between `Next` and `Breaking changes` on this context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24342:
URL: https://github.com/apache/superset/pull/24342#issuecomment-1584635213
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24342](https://app.codecov.io/gh/apache/superset/pull/24342?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3d233d5) into [master](https://app.codecov.io/gh/apache/superset/commit/bdb8bbef32cf9f782b6a7dc7a93c1ad737712536?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bdb8bbe) will **decrease** coverage by `11.25%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3d233d5 differs from pull request most recent head c6212b5. Consider uploading reports for the commit c6212b5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24342 +/- ##
===========================================
- Coverage 69.08% 57.83% -11.25%
===========================================
Files 1905 1905
Lines 74848 74825 -23
Branches 8108 8108
===========================================
- Hits 51705 43272 -8433
- Misses 21031 29441 +8410
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.61% <ø> (+0.01%)` | :arrow_up: |
| python | `60.16% <ø> (-23.11%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.10% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24342?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24342?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `36.58% <ø> (-38.70%)` | :arrow_down: |
... and [302 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24342/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24342:
URL: https://github.com/apache/superset/pull/24342#discussion_r1224623752
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...`
Review Comment:
The difference is that in Next we add things that are not breaking changes but might be helpful when upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24342: chore: remove deprecated api /superset/tables//...
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24342:
URL: https://github.com/apache/superset/pull/24342#issuecomment-1586929064
FYI @dpgaspar #24344 is now merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org