You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by cao zhiqiang <lf...@163.com> on 2021/08/25 15:13:15 UTC
Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-3377
https://issues.apache.org/jira/browse/RANGER-3377
Repository: ranger
Description
-------
Ignore deny conditions to improve the ranger plugin performance by resource config.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
Diff: https://reviews.apache.org/r/73546/diff/1/
Testing
-------
Thanks,
cao zhiqiang
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/#review223394
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Lines 151 (patched)
<https://reviews.apache.org/r/73546/#comment312460>
Please add "else" clause to this, and initialize denyEvaluators, etc. to empty collection as done in the block 163-165.
- Abhay Kulkarni
On Aug. 25, 2021, 4:31 p.m., cao zhiqiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73546/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2021, 4:31 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3377
> https://issues.apache.org/jira/browse/RANGER-3377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ignore deny conditions to improve the ranger plugin performance by resource config.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
>
>
> Diff: https://reviews.apache.org/r/73546/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cao zhiqiang
>
>
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by cao zhiqiang <lf...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/
-----------------------------------------------------------
(Updated 八月 26, 2021, 2:49 a.m.)
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-3377
https://issues.apache.org/jira/browse/RANGER-3377
Repository: ranger
Description
-------
Ignore deny conditions to improve the ranger plugin performance by resource config.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
Diff: https://reviews.apache.org/r/73546/diff/3/
Changes: https://reviews.apache.org/r/73546/diff/2-3/
Testing
-------
Thanks,
cao zhiqiang
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by cao zhiqiang <lf...@163.com>.
> On 八月 25, 2021, 4:52 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
> > Lines 151 (patched)
> > <https://reviews.apache.org/r/73546/diff/2/?file=2252274#file2252274line151>
> >
> > Only when enabled, denyEvaluators/allowExceptionEvaluators/denyExceptionEvaluators should be initialized. Wouldn't this require dropping "!" in this 'if'? Please review.
Yes, I misunderstand this config enableDenyAndExceptionsInPolicies.
- cao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/#review223396
-----------------------------------------------------------
On 八月 26, 2021, 2:49 a.m., cao zhiqiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73546/
> -----------------------------------------------------------
>
> (Updated 八月 26, 2021, 2:49 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3377
> https://issues.apache.org/jira/browse/RANGER-3377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ignore deny conditions to improve the ranger plugin performance by resource config.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
>
>
> Diff: https://reviews.apache.org/r/73546/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cao zhiqiang
>
>
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/#review223396
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Lines 151 (patched)
<https://reviews.apache.org/r/73546/#comment312462>
Only when enabled, denyEvaluators/allowExceptionEvaluators/denyExceptionEvaluators should be initialized. Wouldn't this require dropping "!" in this 'if'? Please review.
- Madhan Neethiraj
On Aug. 25, 2021, 4:31 p.m., cao zhiqiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73546/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2021, 4:31 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3377
> https://issues.apache.org/jira/browse/RANGER-3377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ignore deny conditions to improve the ranger plugin performance by resource config.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
>
>
> Diff: https://reviews.apache.org/r/73546/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cao zhiqiang
>
>
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by cao zhiqiang <lf...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/
-----------------------------------------------------------
(Updated 八月 25, 2021, 4:31 p.m.)
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-3377
https://issues.apache.org/jira/browse/RANGER-3377
Repository: ranger
Description
-------
Ignore deny conditions to improve the ranger plugin performance by resource config.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
Diff: https://reviews.apache.org/r/73546/diff/2/
Changes: https://reviews.apache.org/r/73546/diff/1-2/
Testing
-------
Thanks,
cao zhiqiang
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by cao zhiqiang <lf...@163.com>.
> On 八月 25, 2021, 4:24 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
> > Lines 157 (patched)
> > <https://reviews.apache.org/r/73546/diff/1/?file=2252272#file2252272line157>
> >
> > Please add a 'else' here to assign denyEvaluators, allowExceptionEvaluators and denyExceptionEvaluators with Collections.emptyList() - similar to #165 - #167.
ok!
- cao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/#review223392
-----------------------------------------------------------
On 八月 25, 2021, 4:31 p.m., cao zhiqiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73546/
> -----------------------------------------------------------
>
> (Updated 八月 25, 2021, 4:31 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3377
> https://issues.apache.org/jira/browse/RANGER-3377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ignore deny conditions to improve the ranger plugin performance by resource config.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
>
>
> Diff: https://reviews.apache.org/r/73546/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cao zhiqiang
>
>
Re: Review Request 73546: Improve hdfs ranger plugin performance for
ignore deny conditions
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73546/#review223392
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Lines 157 (patched)
<https://reviews.apache.org/r/73546/#comment312458>
Please add a 'else' here to assign denyEvaluators, allowExceptionEvaluators and denyExceptionEvaluators with Collections.emptyList() - similar to #165 - #167.
- Madhan Neethiraj
On Aug. 25, 2021, 3:13 p.m., cao zhiqiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73546/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2021, 3:13 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-3377
> https://issues.apache.org/jira/browse/RANGER-3377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ignore deny conditions to improve the ranger plugin performance by resource config.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ecd6cb746
>
>
> Diff: https://reviews.apache.org/r/73546/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cao zhiqiang
>
>