You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:53:46 UTC
Review Request 61289: Removed unnecessary includes of
`StoutConfigure`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61289/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Removed unnecessary includes of `StoutConfigure`.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
src/master/cmake/MasterConfigure.cmake 173dc36b5a1b7ff23cd0542ea4313ae6e5e0ae3f
src/slave/cmake/AgentConfigure.cmake af2f74f82b68920427f36c0c863b97c0191b8f06
Diff: https://reviews.apache.org/r/61289/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61289: Removed unnecessary includes of
`StoutConfigure`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61289/#review182355
-----------------------------------------------------------
Ship it!
[Tentative "Ship It!" as I review this entire chain.]
Going to mention stout being an interface library as a reason why these lines are unnecessary.
- Joseph Wu
On Aug. 1, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61289/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:53 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary includes of `StoutConfigure`.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
> src/master/cmake/MasterConfigure.cmake 173dc36b5a1b7ff23cd0542ea4313ae6e5e0ae3f
> src/slave/cmake/AgentConfigure.cmake af2f74f82b68920427f36c0c863b97c0191b8f06
>
>
> Diff: https://reviews.apache.org/r/61289/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>