You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/07 08:47:03 UTC
[GitHub] rymanluk commented on a change in pull request #16: Add event
callbacks on command handlers
rymanluk commented on a change in pull request #16: Add event callbacks on command handlers
URL: https://github.com/apache/mynewt-mcumgr/pull/16#discussion_r231420363
##########
File path: cmd/img_mgmt/src/img_mgmt.c
##########
@@ -424,11 +425,15 @@ img_mgmt_upload(struct mgmt_ctxt *ctxt)
return rc;
}
img_mgmt_ctxt.len = len;
+
+ status = IMG_MGMT_STATUS_UPLOAD_START;
} else {
if (!img_mgmt_ctxt.uploading) {
return MGMT_ERR_EINVAL;
}
+ status = IMG_MGMT_STATUS_UPLOAD_ONGOING;
Review comment:
Did you consider error status? Once it is set as ONGOING, below I can find couple of places where we could leave without a success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services