You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/07 13:08:39 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #9374:
[FLINK-13581][coordination][tests] Harden BatchFineGrainedRecoveryITCase
tillrohrmann commented on a change in pull request #9374: [FLINK-13581][coordination][tests] Harden BatchFineGrainedRecoveryITCase
URL: https://github.com/apache/flink/pull/9374#discussion_r311474017
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
##########
@@ -616,7 +616,8 @@ public String getWebInterfaceURL() {
// RestClient Helper
//-------------------------------------------------------------------------
- private <M extends MessageHeaders<EmptyRequestBody, P, U>, U extends MessageParameters, P extends ResponseBody> CompletableFuture<P>
+ @VisibleForTesting
Review comment:
Why do we need to make this visible for testing? I'd like to separate production from testing code as much as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services