You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kosiew (via GitHub)" <gi...@apache.org> on 2026/01/09 13:25:56 UTC

[I] Add non-TopK benchmark variants for Utf8/Utf8View string aggregates [datafusion]

kosiew opened a new issue, #19713:
URL: https://github.com/apache/datafusion/issues/19713

   
   ## Summary
   Add benchmark variants that run string-aggregate workloads with TopK disabled (representative case) in addition to the existing TopK-enabled worst-case benchmarks, so we can directly compare performance and verify correctness across `Utf8` and `Utf8View` group keys.
   
   ## Background
   - The current `datafusion/core/benches/topk_aggregate.rs` benchmarks exercise the TopK-enabled code path for string aggregates.
   - @haohuaijin  [suggested adding non-TopK benchmarks so we can compare the TopK and non-TopK behavior/performances](https://github.com/apache/datafusion/pull/19285#discussion_r2668719929) and validate the TopK fix in PR #19285.
   
   ## Why this matters
   - Allows straightforward measurement of TopK's benefit (or regression) relative to the fallback path.
   - Helps validate correctness (e.g., Utf8View grouping) under both code paths.
   - Provides repeatable benchmarks to include in PRs and discussions.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Add non-TopK benchmark variants for Utf8/Utf8View string aggregates [datafusion]

Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on issue #19713:
URL: https://github.com/apache/datafusion/issues/19713#issuecomment-4096106752

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Add non-TopK benchmark variants for Utf8/Utf8View string aggregates [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #19713: Add non-TopK benchmark variants for Utf8/Utf8View string aggregates
URL: https://github.com/apache/datafusion/issues/19713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org