[jira] [Commented] (TAJO-1345) Implement logical plan part and DDL executor for alter partition.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611996#comment-14611996 ] 

ASF GitHub Bot commented on TAJO-1345:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/618#discussion_r33780996
  
    --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java ---
    @@ -348,7 +346,9 @@ public void alterTable(CatalogProtos.AlterTableDescProto alterTableDescProto) th
             if(!partitions.containsKey(tableName)) {
               throw new NoSuchPartitionException(databaseName, tableName, partitionName);
             } else {
    -          partitions.remove(partitionName);
    +          Map<String, CatalogProtos.PartitionDescProto> protoMap = partitions.get(tableName);
    +          protoMap.remove(partitionName);
    +          partitions.put(tableName, protoMap);
    --- End diff --
    
    Sorry. it's very trivial, but this line seems unnecessary.


> Implement logical plan part and DDL executor for alter partition.
> -----------------------------------------------------------------
>
>                 Key: TAJO-1345
>                 URL: https://issues.apache.org/jira/browse/TAJO-1345
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1345.patch
>
>
> See the title. The main objective of this issue is to implement the logical planning part and the DDL executor part for alter table partition support.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)