You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/07 22:16:40 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3900:
Refactor in preparation for the ORCRecordReader
codecov-io edited a comment on issue #3900: Refactor in preparation for the ORCRecordReader
URL: https://github.com/apache/incubator-pinot/pull/3900#issuecomment-468837892
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=h1) Report
> Merging [#3900](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/63f0d3d386079b0ba63a880eaf84464742ba4814?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `35.48%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3900 +/- ##
===========================================
- Coverage 67.26% 67.2% -0.06%
Complexity 4 4
===========================================
Files 1032 1032
Lines 50881 50907 +26
Branches 7108 7110 +2
===========================================
- Hits 34223 34211 -12
- Misses 14322 14357 +35
- Partials 2336 2339 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inot/core/data/readers/GenericRowRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvR2VuZXJpY1Jvd1JlY29yZFJlYWRlci5qYXZh) | `94.11% <0%> (-5.89%)` | `0 <0> (ø)` | |
| [...data/readers/MultiplePinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvTXVsdGlwbGVQaW5vdFNlZ21lbnRSZWNvcmRSZWFkZXIuamF2YQ==) | `72.72% <0%> (-0.67%)` | `0 <0> (ø)` | |
| [.../pinot/core/minion/segment/MapperRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9NYXBwZXJSZWNvcmRSZWFkZXIuamF2YQ==) | `81.08% <0%> (-2.26%)` | `0 <0> (ø)` | |
| [...pinot/core/minion/segment/ReducerRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vc2VnbWVudC9SZWR1Y2VyUmVjb3JkUmVhZGVyLmphdmE=) | `90.19% <0%> (-1.81%)` | `0 <0> (ø)` | |
| [...ealtime/converter/RealtimeSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `58.33% <0%> (-2.54%)` | `0 <0> (ø)` | |
| [...he/pinot/core/data/readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvVGhyaWZ0UmVjb3JkUmVhZGVyLmphdmE=) | `82% <0%> (-1.68%)` | `0 <0> (ø)` | |
| [...va/org/apache/pinot/core/minion/SegmentPurger.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vU2VnbWVudFB1cmdlci5qYXZh) | `76.19% <0%> (-0.92%)` | `0 <0> (ø)` | |
| [...ache/pinot/core/minion/BackfillDateTimeColumn.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vQmFja2ZpbGxEYXRlVGltZUNvbHVtbi5qYXZh) | `54.68% <0%> (-0.87%)` | `0 <0> (ø)` | |
| [...ot/core/data/readers/PinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `90.9% <0%> (-1.69%)` | `0 <0> (ø)` | |
| [...ache/pinot/core/data/readers/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQXZyb1JlY29yZFJlYWRlci5qYXZh) | `83.33% <0%> (-1.78%)` | `0 <0> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-pinot/pull/3900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=footer). Last update [63f0d3d...43c80d1](https://codecov.io/gh/apache/incubator-pinot/pull/3900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org