[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14836: [bugfix](compaction) fix promotion size bug

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #14836:
URL: https://github.com/apache/doris/pull/14836#discussion_r1039681888


##########
be/src/olap/page_cache.cpp:
##########
@@ -64,7 +64,7 @@ bool StoragePageCache::lookup(const CacheKey& key, PageCacheHandle* handle,
 
 void StoragePageCache::insert(const CacheKey& key, const Slice& data, PageCacheHandle* handle,
                               segment_v2::PageTypePB page_type, bool in_memory) {
-    auto deleter = [](const doris::CacheKey& key, void* value) { delete[] (uint8_t*)value; };
+    auto deleter = [](const doris::CacheKey& key, void* value) { delete[](uint8_t*) value; };

Review Comment:
   warning: parameter 'key' is unused [misc-unused-parameters]
   
   ```suggestion
       auto deleter = [](const doris::CacheKey&  /*key*/, void* value) { delete[](uint8_t*) value; };
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org