You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/07/29 23:47:40 UTC

[GitHub] incubator-pirk pull request #33: [PIRK-28] [WIP]: Logger Statements Not Work...

GitHub user smarthi opened a pull request:

    https://github.com/apache/incubator-pirk/pull/33

    [PIRK-28] [WIP]: Logger Statements Not Working in/from Drivers

    I do see that the log4j2.properties is being packaged into target/classes folder, and the main method should automatically pick it up from there. 
    
    There was an unnecessary dependency on log4j 1.2 in POM which has now been removed and could have been shadowing the log4j2 jar.
    
    Could someone please test this patch and confirm if its working? I'll check on this later tonight.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/incubator-pirk PIRK-28

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 3fde0ae94144b6a147455b352420a9693ddbebfc
Author: smarthi <sm...@apache.org>
Date:   2016-07-29T23:44:03Z

    PIRK-28 : Logger Statements Not Working in/from Drivers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    This PR is good and working now, Phew!! 
    Please review and merge after Travis Build passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    If you run the QuerierDriver (or ResponderDriver) locally you can test it out. For example, if you run
    
    `java -cp target/pirk-0.0.1-SNAPSHOT-exe.jar org.apache.pirk.querier.wideskies.QuerierDriver`
    
    it will use the properties loaded from the querier.properties file packaged with the jar and should bark the error messages from QuerierProps. Currently, it does not; you will just get the help message that prints out via QuerierDriverCLI line 71. If you change all logger.info/logger.error messages in QuerierProps to System.out.println you will see the output that you are supposed to see via the logging mechanisms. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #33: [PIRK-28]: Logger Statements Not Working in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    Does not appear to be working



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28]: Logger Statements Not Working in/from D...

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    +1 Thanks for tracking this down!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    Please see the jira entry for the status on this. Also in one of the previous PRs, changed the jar package naming to be prefixed with apache- . The jar would now be apache-pirk-0.0.1-SNAPSHOT-exe.jar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    How do I test this out locally? Is there an example that I could go by?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #33: [PIRK-28] [WIP]: Logger Statements Not Working in/...

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/33
  
    I'll take a look



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---