[GitHub] syed commented on issue #2204: Http handler

[gi...@git.apache.org]

syed commented on issue #2204: Http handler
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-318524162
 
 
   Good job on finally opening the PR Sachin. Can you do a few things first:
   
   
   1. Create a JIRA ticket at issues.apache.org Under the `Cloudstack` project giving a basic overview of your change (you can basically copy paste the description from here)
   2. Rename the PR from `http Handler` to a more descriptive message like `[CLOUDSTACK-<jiraID>] Adding Support for NoVNC Console for KVM`
   3. Rebase all your commits to a single commit.
   4. Make sure the new files that you have added (for example the NoVNC websocket handler) have the apache licence at the top. You can look at any other java file and copy the licence from there
   5. Finally, give a little more description about your approach and how you are proxying the websocket connection and the change to replace the `HttpHandler` with `Jetty`
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services