You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/12/11 22:46:50 UTC

[GitHub] [hadoop] rbalamohan commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath

rbalamohan commented on issue #1754: HADOOP-16751: DurationInfo text parsing/formatting should be moved out of hotpath
URL: https://github.com/apache/hadoop/pull/1754#issuecomment-564767793
 
 
   Thanks for the review Steve. 
   
   It would be evaluated only once on need basis (textStr takes care of that). 
   
   Having `String text` based on `(logAtInfo && log.isInfoEnabled() || log.isDebugEnabled()`, it would fail in some cases. E.g invoking `toString` on `new DurationInfo(log, false, "test")` would end up with "null" for text.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org