You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/15 06:55:27 UTC
[GitHub] [superset] jawabuu opened a new issue #13124: Dashboard Email Reports Selector displays ID instead of Name
jawabuu opened a new issue #13124:
URL: https://github.com/apache/superset/issues/13124
## Screenshot
## Description
When creating a Dashboard Email report the selector displays the ID instead of the name.
For Example `Dashboard <1>` instead of `World Bank's Data`
I have observed this in version `1.0.0` and `1.0.1`
Chart Email reports work just fine.
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
Display Dashboard Name.
`bug:cosmetic`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jawabuu commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
jawabuu commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-824385107
@zuzana-vej The issue still exists. The PR to close this has not been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779155749
Have you turned off `ENABLE_REACT_CRUD_VIEWS` by any chance?
The new alerts and reports kind of depend on it: https://github.com/apache/superset/blob/52ba82fb8b9f1ce5519f1a13f6417a0ce486e7df/superset/views/alerts.py#L80
@lilykuang @nytai do you think whether it makes sense to force turning on `ENABLE_REACT_CRUD_VIEWS` when `ALERT_REPORTS` is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-780605361
@nytai agree, planning on removing the MVC CRUD `ModelView` code also. But we can deprecate the flag now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779377570
@ktmud We could throw a warning if `ALERT_REPORTS` is enabled, but `ENABLE_REACT_CRUD_VIEWS` is not. I think that fully deprecating the `ENABLE_REACT_CRUD_VIEWS` feature flag makes more sense, I don't think there's any strong case for continuing to support the old FAB views at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-947098995
@jawabuu have you try using the new alerts and reports behind feature flag? it should be more stable and usable than the legacy solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #13124:
URL: https://github.com/apache/superset/issues/13124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jawabuu commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
jawabuu commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779156552
@ktmud I had turned it off. Let me turn it on and retry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stale[bot] commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-868936175
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jawabuu commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
jawabuu commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779076032
Hey @ktmud
Thank you
I have the following set up
```
FEATURE_FLAGS = {
"KV_STORE": True,
"SHARE_QUERIES_VIA_KV_STORE": True,
"ENABLE_TEMPLATE_PROCESSING": True,
"ENABLE_REACT_CRUD_VIEWS": False,
"ROW_LEVEL_SECURITY": True,
"ALERT_REPORTS": True,
"DASHBOARD_NATIVE_FILTERS": True,
"THUMBNAILS": True,
}
```
However, when I visit `Settings>Alerts & Reports` I get a 404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-824374509
@jawabuu can you please confirm if this issue is still existing / close this GH# if it's resolved? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jawabuu commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
jawabuu commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779219346
@ktmud
I am now able to view the reports and have set up a test report to be sent every minute.
I have celery workers and beat running as well as cache configured.
I have not received any so far, is there any further configuration I need to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jawabuu commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
jawabuu commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779232417
Managed to find these from github search
```
from celery.schedules import crontab
CELERYBEAT_SCHEDULE = {
'email_reports.schedule_hourly': {
'task': 'email_reports.schedule_hourly',
'schedule': crontab(minute='*/59'),
},
'alerts.schedule_check': {
'task': 'alerts.schedule_check',
'schedule': crontab(minute='*/4'')
},
'reports.scheduler': {
'task': 'reports.scheduler',
'schedule': crontab(minute='*/5'),
},
'reports.prune_log': {
'task': 'reports.prune_log',
'schedule': crontab(minute=0, hour=0),
},
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #13124: Dashboard Email Reports Selector displays ID instead of Name
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13124:
URL: https://github.com/apache/superset/issues/13124#issuecomment-779064509
There is an open PR for this: https://github.com/apache/superset/pull/11776
Although you can now also try out the new Alert & Report manager by turning on the [`ALERT_REPORTS`](https://github.com/apache/superset/blob/50fa10054fd5d2c28553c4ffd754e12bdedef5da/RELEASING/release-notes-1-0/README.md#feature-flags) feature flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org