You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/29 07:07:15 UTC
[GitHub] [hbase] ankitjain64 opened a new pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
ankitjain64 opened a new pull request #2327:
URL: https://github.com/apache/hbase/pull/2327
JIRA: https://issues.apache.org/jira/browse/HBASE-24764
JIRA Description:
Today, if a user needs to apply some common base peer configs to all the replication peers on the cluster, the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet.
As part of this JIRA, we plan to add the support to have base replication peer configs as part of hbase-site.xml like hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily updated and applied as part of a rolling restart.
Example below:
```
<property>
<name>hbase.replication.peer.base.configs</name>
<value>hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123</value>
</property>
```
This property will be empty by default, but user can override to have base configs in place.
The final peer configuration would be a merge of whatever is currently present or what users override during the peer creation/update (if any) + this newly added base config.
Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration.
By this new Jira we are extending the support to update peer configs via hbase-site.xml and hence WalEntryFilters or any other peer property can be applied just by rolling restart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-683267934
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 18s | branch-1 passed |
| +1 :green_heart: | compile | 1m 0s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 8s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 9s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 59s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 19s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 0m 33s | hbase-client: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 33s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 6s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 42s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 121m 1s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. |
| | | 173m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2327 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c9dbf305aeeb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2327/out/precommit/personality/provided.sh |
| git revision | branch-1 / 31e47af |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/1/artifact/out/diff-checkstyle-hbase-client.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/1/testReport/ |
| Max. process+thread count | 4357 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
bharathv commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-685164720
Will do, waiting for a +1 from Stack on the original PR and then I can sign off on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ankitjain64 commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
ankitjain64 commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-685160021
@bharathv : Can you please have a look at this ? This is for branch-1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-685158343
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 22s | branch-1 passed |
| +1 :green_heart: | compile | 1m 1s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 11s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 23s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 2s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 9s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 21s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 11s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 43s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 54s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 5s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 4m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 43s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 133m 18s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
| | | 187m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2327 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b9a3432f1cee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2327/out/precommit/personality/provided.sh |
| git revision | branch-1 / 80ce76c |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/3/testReport/ |
| Max. process+thread count | 4400 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-693856170
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 7s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 14s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 25s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 31s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 10s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 24s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 0s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 9s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| +1 :green_heart: | compile | 1m 15s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 1m 15s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 23s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 10s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 1m 8s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 45s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 7m 27s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 52s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 143m 52s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 211m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2327 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0b60862defd6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2327/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7801b45 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/4/testReport/ |
| Max. process+thread count | 4613 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/4/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ankitjain64 commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
ankitjain64 commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-693136239
@bharathv : Can you take a look at this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv merged pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #2327:
URL: https://github.com/apache/hbase/pull/2327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#issuecomment-684137266
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 54s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 0s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 8s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 14s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 59s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 7s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 17s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | compile | 1m 8s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 1m 8s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 6s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 6s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 42s | hbase-client in the patch passed. |
| -1 :x: | unit | 123m 52s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 182m 33s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.replication.TestReplicationKillSlaveRS |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2327 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2313d063eb29 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2327/out/precommit/personality/provided.sh |
| git revision | branch-1 / 041debd |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/2/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/2/testReport/ |
| Max. process+thread count | 4394 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2327/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #2327:
URL: https://github.com/apache/hbase/pull/2327#discussion_r489574840
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java
##########
@@ -99,6 +105,36 @@ public ReplicationPeerConfig setBandwidth(long bandwidth) {
return this;
}
+ /**
+ * Helper method to add base peer configs from Configuration to ReplicationPeerConfig
+ * if not present in latter.
+ *
+ * This merges the user supplied peer configuration
+ * {@link org.apache.hadoop.hbase.replication.ReplicationPeerConfig} with peer configs
+ * provided as property hbase.replication.peer.base.configs in hbase configuration.
+ * Expected format for this hbase configuration is "k1=v1;k2=v2,v2_1". Original value
+ * of conf is retained if already present in ReplicationPeerConfig.
+ *
+ * @param conf Configuration
+ */
+ public void addBasePeerConfigsIfNotPresent(Configuration conf) {
+ String basePeerConfigs = conf.get(HBASE_REPLICATION_PEER_BASE_CONFIG, "");
+ Map<String,String> receivedPeerConfigMap = this.getConfiguration();
+
+ if (basePeerConfigs.length() != 0) {
+ Map<String, String> basePeerConfigMap = Splitter.on(';').trimResults().omitEmptyStrings()
+ .withKeyValueSeparator("=").split(basePeerConfigs);
+ for (Map.Entry<String,String> entry : basePeerConfigMap.entrySet()) {
+ String configName = entry.getKey();
+ String configValue = entry.getValue();
+ // Only override if base config does not exist in existing replication peer configs
+ if (!receivedPeerConfigMap.containsKey(configName)) {
Review comment:
nit: just use this.configuration directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org