You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/10/08 14:45:41 UTC

svn commit: r1630088 - /tomcat/trunk/build.xml

Author: markt
Date: Wed Oct  8 12:45:40 2014
New Revision: 1630088

URL: http://svn.apache.org/r1630088
Log:
Use 24 hour clock in build stamp

Modified:
    tomcat/trunk/build.xml

Modified: tomcat/trunk/build.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1630088&r1=1630087&r2=1630088&view=diff
==============================================================================
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Oct  8 12:45:40 2014
@@ -227,7 +227,7 @@
     <format property="year" pattern="yyyy" locale="en"/>
     <format property="today" pattern="MMM d yyyy" locale="en"/>
     <format property="today-iso-8601" pattern="yyyy-MM-dd" locale="en"/>
-    <format property="tstamp" pattern="hh:mm:ss"/>
+    <format property="tstamp" pattern="HH:mm:ss"/>
   </tstamp>
   <filterset id="version.filters">
     <filter token="YEAR" value="${year}"/>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1630088 - /tomcat/trunk/build.xml

Posted by Mark Thomas <ma...@apache.org>.
On 08/10/2014 13:50, Konstantin Kolinko wrote:
> 2014-10-08 16:45 GMT+04:00  <ma...@apache.org>:
>> Author: markt
>> Date: Wed Oct  8 12:45:40 2014
>> New Revision: 1630088
>>
>> URL: http://svn.apache.org/r1630088
>> Log:
>> Use 24 hour clock in build stamp
> 
> Good catch!
> 
> Maybe add timezone information as well?

Good idea.

I made sure we used UTC everywhere otherwise you could get strange
results if the timezone moved you to the next/previous day compared to UTC.

Mark


> 
> 
>> Modified:
>>     tomcat/trunk/build.xml
>>
>> Modified: tomcat/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1630088&r1=1630087&r2=1630088&view=diff
>> ==============================================================================
>> --- tomcat/trunk/build.xml (original)
>> +++ tomcat/trunk/build.xml Wed Oct  8 12:45:40 2014
>> @@ -227,7 +227,7 @@
>>      <format property="year" pattern="yyyy" locale="en"/>
>>      <format property="today" pattern="MMM d yyyy" locale="en"/>
>>      <format property="today-iso-8601" pattern="yyyy-MM-dd" locale="en"/>
>> -    <format property="tstamp" pattern="hh:mm:ss"/>
>> +    <format property="tstamp" pattern="HH:mm:ss"/>
>>    </tstamp>
>>    <filterset id="version.filters">
>>      <filter token="YEAR" value="${year}"/>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1630088 - /tomcat/trunk/build.xml

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-10-08 16:45 GMT+04:00  <ma...@apache.org>:
> Author: markt
> Date: Wed Oct  8 12:45:40 2014
> New Revision: 1630088
>
> URL: http://svn.apache.org/r1630088
> Log:
> Use 24 hour clock in build stamp

Good catch!

Maybe add timezone information as well?


> Modified:
>     tomcat/trunk/build.xml
>
> Modified: tomcat/trunk/build.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1630088&r1=1630087&r2=1630088&view=diff
> ==============================================================================
> --- tomcat/trunk/build.xml (original)
> +++ tomcat/trunk/build.xml Wed Oct  8 12:45:40 2014
> @@ -227,7 +227,7 @@
>      <format property="year" pattern="yyyy" locale="en"/>
>      <format property="today" pattern="MMM d yyyy" locale="en"/>
>      <format property="today-iso-8601" pattern="yyyy-MM-dd" locale="en"/>
> -    <format property="tstamp" pattern="hh:mm:ss"/>
> +    <format property="tstamp" pattern="HH:mm:ss"/>
>    </tstamp>
>    <filterset id="version.filters">
>      <filter token="YEAR" value="${year}"/>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org