You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/02 20:37:02 UTC

[kudu-CR] Integrate ColumnPredicate into client and server

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2138

to look at the new patch set (#11).

Change subject: Integrate ColumnPredicate into client and server
......................................................................

Integrate ColumnPredicate into client and server

This commit integrates the new ColumnPredicate type into the ScanSpec class. The
predicate encoder functionality has been subsumed into the ScanSpec and
ColumnPredicate classes.

In addition, we now 'lift' implicit predicates from the lower and upper primary
key bounds into the set of column predicates when the scan spec is optimized.

Finally, this commit refactors row_key-util into key_util, and makes the utility
methods able to work on primary keys as well as range keys.

Change-Id: Ife6852680b7f59fddee688e5702c1a70944f7622
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/kududb/client/ColumnRangePredicate.java
M java/kudu-client/src/test/java/org/kududb/client/TestColumnRangePredicate.java
M src/kudu/client/client.cc
M src/kudu/client/scan_predicate-internal.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/common/CMakeLists.txt
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
R src/kudu/common/key_util-test.cc
A src/kudu/common/key_util.cc
A src/kudu/common/key_util.h
M src/kudu/common/partial_row.h
M src/kudu/common/partition.cc
D src/kudu/common/predicate_encoder-test.cc
D src/kudu/common/predicate_encoder.cc
D src/kudu/common/predicate_encoder.h
D src/kudu/common/row_key-util.cc
D src/kudu/common/row_key-util.h
A src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/tserver/tserver.proto
40 files changed, 1,761 insertions(+), 1,186 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/2138/11
-- 
To view, visit http://gerrit.cloudera.org:8080/2138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife6852680b7f59fddee688e5702c1a70944f7622
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>