You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 20:10:26 UTC
[GitHub] [arrow] lwhite1 opened a new pull request, #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
lwhite1 opened a new pull request, #14534:
URL: https://github.com/apache/arrow/pull/14534
Prevent vectors from being closed when ArrowVectorIterator closes in the case where the reuseVectorSchemaRoot flag is set to false.
Test in JDBCToArrowVectorIteratorTest was updated to cover this case.
Tests in UnreliableMetaDataTest were modified to manually close VectorSchemaRoots, preventing an unclosed buffer exception being thrown when the RootAllocator was closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1294024540
https://issues.apache.org/jira/browse/ARROW-18178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1295166591
> LGTM.
>
> Is there somewhere in the Javadocs or prose docs that this behavior should be described? (That is: if the VSR is reused, closing the iterator closes the root as expected; else the caller is expected to manage all roots)
Good catch. It is mentioned in the method javadoc for next(). I just pushed a commit that makes it explicit in the close() method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14534:
URL: https://github.com/apache/arrow/pull/14534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1294018669
@lidavidm If you could review that would be helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1296048541
Benchmark runs are scheduled for baseline = 9f4c632fa9a22f7f0ea793b9bc40d9ee8d8ffad7 and contender = f57ad932664d50444880e54f18e31b1ce1adf1ef. f57ad932664d50444880e54f18e31b1ce1adf1ef is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/09274cf538974bdd85e1c3296d175704...18483b92228c482cba7a006bb30f0e7f/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fcaf263f55f74f3fa4c181961b1abac0...c18f4a48fbb143b5ad23fa3f59278c0e/)
[Finished :arrow_down:1.9% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/560510c75141485eab8b9113921d1b43...09ebe1c03499408988f4fd2e55c0bc06/)
[Finished :arrow_down:0.18% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/62e83e44aac14b32b96aa5cdef3aea1f...9eb6f7ad2dcc4786a3ab7b6a42eebe46/)
Buildkite builds:
[Finished] [`f57ad932` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1782)
[Failed] [`f57ad932` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1803)
[Finished] [`f57ad932` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1770)
[Finished] [`f57ad932` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1795)
[Finished] [`9f4c632f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1781)
[Failed] [`9f4c632f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1802)
[Finished] [`9f4c632f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1769)
[Finished] [`9f4c632f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1794)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1294024585
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14534: ARROW-18178: [Java] ArrowVectorIterator incorrectly closes Vectors
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14534:
URL: https://github.com/apache/arrow/pull/14534#issuecomment-1296048616
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/560510c75141485eab8b9113921d1b43...09ebe1c03499408988f4fd2e55c0bc06/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org