You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/24 13:19:05 UTC
[GitHub] [flink] wsry opened a new pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
wsry opened a new pull request #18474:
URL: https://github.com/apache/flink/pull/18474
## What is the purpose of the change
Currently, for sort-shuffle the generation of subpartition data storage order is random shuffle. However, if there is no enough resources to run the downstream consumer tasks in parallel, the performance can be influenced because of the random disk IO caused by the random subpartition data storage order. This ticket aims to improve this scenario.
## Brief change log
- Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020097932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044",
"triggerID" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b92227b39fabde5919ab161e12a6f7e272e70f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020097932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ddd5117fae54a99edcdde15cf5cf2f5e0bac2279",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ddd5117fae54a99edcdde15cf5cf2f5e0bac2279",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ddd5117fae54a99edcdde15cf5cf2f5e0bac2279 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on a change in pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on a change in pull request #18474:
URL: https://github.com/apache/flink/pull/18474#discussion_r791322643
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java
##########
@@ -492,10 +490,13 @@ public int getNumberOfQueuedBuffers(int targetSubpartition) {
}
private int[] getRandomSubpartitionOrder(int numSubpartitions) {
- List<Integer> list =
- IntStream.range(0, numSubpartitions).boxed().collect(Collectors.toList());
- Collections.shuffle(list);
- return list.stream().mapToInt(Integer::intValue).toArray();
+ int[] order = new int[numSubpartitions];
+ Random random = new Random();
+ int shift = random.nextInt(numSubpartitions);
Review comment:
If `shift` is 0, the returned array may not be changed.
In addition, this patch may cause the actual traversal order not to change, but only the starting position to be modified. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020097932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044",
"triggerID" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b92227b39fabde5919ab161e12a6f7e272e70f7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020097932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044",
"triggerID" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b92227b39fabde5919ab161e12a6f7e272e70f7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30044)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on a change in pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
TanYuxin-tyx commented on a change in pull request #18474:
URL: https://github.com/apache/flink/pull/18474#discussion_r791322643
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java
##########
@@ -492,10 +490,13 @@ public int getNumberOfQueuedBuffers(int targetSubpartition) {
}
private int[] getRandomSubpartitionOrder(int numSubpartitions) {
- List<Integer> list =
- IntStream.range(0, numSubpartitions).boxed().collect(Collectors.toList());
- Collections.shuffle(list);
- return list.stream().mapToInt(Integer::intValue).toArray();
+ int[] order = new int[numSubpartitions];
+ Random random = new Random();
+ int shift = random.nextInt(numSubpartitions);
Review comment:
If `shift` is 0, the returned array may not be changed.
In addition, this patch may cause the actual traversal order not to change, but only the starting position to be modified. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #18474:
URL: https://github.com/apache/flink/pull/18474#discussion_r792449522
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java
##########
@@ -492,10 +490,13 @@ public int getNumberOfQueuedBuffers(int targetSubpartition) {
}
private int[] getRandomSubpartitionOrder(int numSubpartitions) {
- List<Integer> list =
- IntStream.range(0, numSubpartitions).boxed().collect(Collectors.toList());
- Collections.shuffle(list);
- return list.stream().mapToInt(Integer::intValue).toArray();
+ int[] order = new int[numSubpartitions];
+ Random random = new Random();
+ int shift = random.nextInt(numSubpartitions);
Review comment:
Yes, it is expected. The motivation is for better sequential disk IO when there is no enough resources to run the downstream consumer tasks in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020097932
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b92227b39fabde5919ab161e12a6f7e272e70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b92227b39fabde5919ab161e12a6f7e272e70f7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18474:
URL: https://github.com/apache/flink/pull/18474#issuecomment-1020098200
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ddd5117fae54a99edcdde15cf5cf2f5e0bac2279 (Mon Jan 24 13:24:42 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #18474:
URL: https://github.com/apache/flink/pull/18474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org