[GitHub] [skywalking-banyandb] hanahmily commented on pull request #261: Implement Write-ahead Logging

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily commented on PR #261:
URL: https://github.com/apache/skywalking-banyandb/pull/261#issuecomment-1475448566

   > There are some things that need help:
   > 
   > * During disk flushing, in order to avoid blocking writes, I cloned the buffer so that I can continue to accept write requests while flushing the disk. However, during asynchronous callbacks, all channels will be notified. At this time, write requests that only write to the buffer should not receive this request, but  they receive it.how can I resolve this issue？
   
   You should have switched to a new flushChannel on switching the buffer. Theoretically, a flush channel sends a notice which indicates its corresponding buffer gets flushed. Based on that, the flush channel seems a field in the `buffer` structure instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org