You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/15 02:37:22 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request
#176: Fix echo NULL character correctly
xiaoxiang781216 opened a new pull request #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request
#176: Fix echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 opened a new pull request #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] lukegluke commented on issue #176: Fix echo
NULL character correctly
Posted by GitBox <gi...@apache.org>.
lukegluke commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614272725
Hi @xiaoxiang781216
Sorry for late reply, for some reason github do not inform me about discussion!
I totally agree that writing back what cu receive from serial is always a good action, and I was surprised why it is not default.
But -f option is **not only** to force write back null char! @Ouss4 is right with -f option cu doesn't stop on escape characters ~.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] lukegluke commented on issue #176: Fix echo
NULL character correctly
Posted by GitBox <gi...@apache.org>.
lukegluke commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614456349
@xiaoxiang781216, but I think https://github.com/apache/incubator-nuttx-apps/pull/176/commits/f00bca3250698da686def67a9a60060e254f2fa6 should be merged to always write back all recevied chars even without -f option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614474344
@lukegluke Ok, I will bring back this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 edited a comment on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614268517
I just created the PR on behalf of Oleg, I had nothing to do with the change itself.
@xiaoxiang781216 the old commit sends back everything without any special treatment, even for commands, was that not desirable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-613871382
> maybe. i don't know what was the motivation of the -f option.
Yes, that's why I remove -f option, writing back what cu receive from serial is always a good action. no any reason don't enable it by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] lukegluke edited a comment on issue #176:
Fix echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
lukegluke edited a comment on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614272725
Hi @xiaoxiang781216
Sorry for late reply, for some reason github do not inform me about discussion!
I totally agree that writing back what cu receive from serial is always a good action, and I was surprised why it is not default.
But -f (forever) option is **not only** to force write back null char! @Ouss4 is right with -f option cu doesn't stop on escape characters ~.
I wrote about this in email with patch, but it was missed here in commit description.
`endless mode: pass all characters and ignore escape sequence, handy to interact with serial devices with binary protocol`
Next time I will do pull request here on github, sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-613871042
@Ouss4 @lukegluke does this change solve what you wanted to solve with the -f option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt merged pull request #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
yamt merged pull request #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 edited a comment on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614268517
I just created the PR on behalf of Oleg, I had nothing to do with the change itself.
@xiaoxiang781216 the old commit sends back everything without any special treatment, even for commands and escape characters, was that not desirable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] lukegluke edited a comment on issue #176:
Fix echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
lukegluke edited a comment on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614272725
Hi @xiaoxiang781216
Sorry for late reply, for some reason github do not inform me about discussion!
I totally agree that writing back what cu receive from serial is always a good action, and I was surprised why it is not default.
But -f option is **not only** to force write back null char! @Ouss4 is right with -f option cu doesn't stop on escape characters ~.
I wrote about this in email with patch, but it was missed here in commit description.
`endless mode: pass all characters and ignore escape sequence, handy to interact with serial devices with binary protocol`
Next time I will do pull request here on github, sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] lukegluke edited a comment on issue #176:
Fix echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
lukegluke edited a comment on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614272725
Hi @xiaoxiang781216
Sorry for late reply, for some reason github do not inform me about discussion!
I totally agree that writing back what cu receive from serial is always a good action, and I was surprised why it is not default.
But -f option is **not only** to force write back null char! @Ouss4 is right with -f option cu doesn't stop on escape characters ~.
I wrote about this in email with patch, but it was missed here in commit description.
`endless mode: pass all characters and ignore escape sequence, handy to interact with serial devices with binary protocol`
Next time I will do pull request here, sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #176:
Fix echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-613853963
it isn't clear to me why you reverted the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614268517
I just created the PR on behalf of Oleg, I had nothing to do with the change itself.
@xiaoxiang781216 the old commit sends back everything without any special treatment, even for commands (with ~), was that not desirable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614378919
@lukegluke thanks for explanation, I can understand -f option now. I will close my PR without merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614604145
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-613868794
maybe. i don't know what was the motivation of the -f option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #176: Fix
echo NULL character correctly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-613858493
> it isn't clear to me why you reverted the change.
This patch add -f option to force write back null char, but I think that the correct behaviour should always write back all recevie char, do you think so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on issue #176: Fix echo NULL
character correctly
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #176: Fix echo NULL character correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/176#issuecomment-614602338
@yamt If you are good with the change please merge.
(Please Rebase and merge to not create a merge commit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services