You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/16 05:55:37 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #2024: [CALCITE-3923] Refactor how planner rules are parameterized

julianhyde commented on a change in pull request #2024:
URL: https://github.com/apache/calcite/pull/2024#discussion_r440602130



##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptRules.java
##########
@@ -157,18 +157,18 @@ private RelOptRules() {
       UnionMergeRule.INSTANCE,
       UnionMergeRule.INTERSECT_INSTANCE,
       UnionMergeRule.MINUS_INSTANCE,
-      ProjectToWindowRule.PROJECT,
+      ProjectToWindowRule.ProjectToLogicalProjectAndWindowRule.INSTANCE,
       FilterMergeRule.INSTANCE,
       DateRangeRules.FILTER_INSTANCE,
       IntersectToDistinctRule.INSTANCE);
 
   static final List<RelOptRule> ABSTRACT_RELATIONAL_RULES = ImmutableList.of(
-      FilterJoinRule.FILTER_ON_JOIN,
-      FilterJoinRule.JOIN,
+      FilterJoinRule.FILTER_ON_JOIN.get(),
+      FilterJoinRule.JOIN.get(),

Review comment:
       I have made the change you suggested. We'll see whether anyone runs into deadlocks.
   
   Fixed in 497fa05.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org