[GitHub] [zookeeper] eolivelli commented on a change in pull request #1010: ZOOKEEPER-3425:ttl node should not have the children and ranking the ttl by expireTime asc for the performance

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1010: ZOOKEEPER-3425:ttl node should not have the children and ranking the ttl by expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#discussion_r300364942
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
 ##########
 @@ -1305,7 +1363,7 @@ public void deserialize(InputArchive ia, String tag) throws IOException {
                 if (ephemeralType == EphemeralType.CONTAINER) {
                     containers.add(path);
                 } else if (ephemeralType == EphemeralType.TTL) {
-                    ttls.add(path);
+                    ttls.add(new TTLNode(path, node.stat.getCtime() + ephemeralType.getValue(node.stat.getEphemeralOwner())));
 
 Review comment:
   How do we deal with backward compatibility?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services