You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2012/07/13 23:12:26 UTC

svn commit: r1361402 - in /ofbiz/trunk/specialpurpose/ecommerce: config/EcommerceUiLabels.xml webapp/ecommerce/catalog/productdetail.ftl

Author: jleroux
Date: Fri Jul 13 21:12:26 2012
New Revision: 1361402

URL: http://svn.apache.org/viewvc?rev=1361402&view=rev
Log:
A patch from Carsten Schinzer "ECommerce application, productdetail is not fully internationalized" https://issues.apache.org/jira/browse/OFBIZ-4962



The i18n in the productdetail.ftl is not complete when featuretree is used to define products. Missing bits:

Reference to existing UI Labels on div productdetail for sizes available
Using a UI Label instead of hard coded "choose option" on the AddItemForm


Modified:
    ofbiz/trunk/specialpurpose/ecommerce/config/EcommerceUiLabels.xml
    ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl

Modified: ofbiz/trunk/specialpurpose/ecommerce/config/EcommerceUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/config/EcommerceUiLabels.xml?rev=1361402&r1=1361401&r2=1361402&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ecommerce/config/EcommerceUiLabels.xml (original)
+++ ofbiz/trunk/specialpurpose/ecommerce/config/EcommerceUiLabels.xml Fri Jul 13 21:12:26 2012
@@ -3186,6 +3186,11 @@
         <value xml:lang="zh">选择间隔</value>
         <value xml:lang="zh_TW">選擇間隔</value>
     </property>
+    <property key="EcommerceSelectOption">
+        <value xml:lang="de">Option wählen</value>
+        <value xml:lang="en">Select Option</value>
+        <value xml:lang="fr">Sélectionnez une option</value>
+    </property>
     <property key="EcommerceSelectedGiftWrap">
         <value xml:lang="da">Vælg gavepapir</value>
         <value xml:lang="de">Ausgewählte Geschenkverpackung</value>

Modified: ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl?rev=1361402&r1=1361401&r2=1361402&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl (original)
+++ ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl Fri Jul 13 21:12:26 2012
@@ -429,10 +429,9 @@ $(function(){
           <#if sizeProductFeatureAndAppls?has_content>
             <div>
               <#if (sizeProductFeatureAndAppls?size == 1)>
-                <#-- TODO : i18n -->
-                Size:
+                ${uiLabelMap.OrderSizeAvailableSingle}:
               <#else>
-                Sizes Available:
+                ${uiLabelMap.OrderSizeAvailableMultiple}:
               </#if>
               <#list sizeProductFeatureAndAppls as sizeProductFeatureAndAppl>
                 ${sizeProductFeatureAndAppl.description?default(sizeProductFeatureAndAppl.abbrev?default(sizeProductFeatureAndAppl.productFeatureId))}<#if sizeProductFeatureAndAppl_has_next>,</#if>
@@ -564,7 +563,7 @@ $(function(){
                     <#list featureList as feature>
                         <#if feature_index == 0>
                             <div>${feature.description}: <select id="FT${feature.productFeatureTypeId}" name="FT${feature.productFeatureTypeId}" onchange="javascript:checkRadioButton();">
-                            <option value="select" selected="selected"> select option </option>
+                            <option value="select" selected="selected">${uiLabelMap.EcommerceSelectOption}</option>
                         <#else>
                             <option value="${feature.productFeatureId}">${feature.description} <#if feature.price?exists>(+ <@ofbizCurrency amount=feature.price?string isoCode=feature.currencyUomId />)</#if></option>
                         </#if>