[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1311: refactor(log): use LOG_INFO_F instead of LOG_INFO (3/3)

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1311:
URL: https://github.com/apache/incubator-pegasus/pull/1311#discussion_r1070881204


##########
src/replica/backup/cold_backup_context.cpp:
##########
@@ -567,31 +573,31 @@ void cold_backup_context::on_upload_chkpt_dir()
     }
 
     if (checkpoint_files.size() <= 0) {
-        LOG_INFO("%s: checkpoint dir is empty, so upload is complete and just start write "
-                 "backup_metadata",
-                 name);
+        LOG_INFO_F("{}: checkpoint dir is empty, so upload is complete and just start write "
+                   "backup_metadata",
+                   name);

Review Comment:
   "backup_metadata" is not an independent parameter, but a part of the first string parameter, so it should not be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org