You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/17 00:24:49 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34009: [SPARK-34378][SQL][AVRO] Enhance AvroSerializer validation to allow extra nullable Avro fields

HyukjinKwon commented on a change in pull request #34009:
URL: https://github.com/apache/spark/pull/34009#discussion_r710604396



##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSchemaHelperSuite.scala
##########
@@ -133,4 +133,27 @@ class AvroSchemaHelperSuite extends SQLTestUtils with SharedSparkSession {
       helperNullable.validateNoExtraCatalystFields(ignoreNullable = false)
     }
   }
+
+  test("validateNoExtraRequiredAvroFields detects required fields and ignores nullable fields") {

Review comment:
       Shall we aadd a JIRA prefix in the test title?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org