You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/30 18:03:47 UTC

Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.


Bugs: MESOS-4556
    https://issues.apache.org/jira/browse/MESOS-4556


Repository: mesos


Description
-------

Fix ShasumTest.SHA512SimpleFile failed on centos7.


Diffs
-----

  src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
  src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 

Diff: https://reviews.apache.org/r/43014/diff/


Testing
-------

# check in CentOS 7.
sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"


Thanks,

haosdent huang

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117120
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43014]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by haosdent huang <ha...@gmail.com>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.

which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Shuai Lin <li...@gmail.com>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
>     I thought `which` will work only if the command is in the path.

The command "which" is not avaiable in the `centos:7` image

```sh
$ docker run -it --rm centos:7 which ls
exec: "which": executable file not found in $PATH
Error response from daemon: Cannot start container f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System error: exec: "which": executable file not found in $PATH
```

To get it one need to run "yum install which".


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On Jan. 30, 2016, 9:11 a.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
>     I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
>     The command "which" is not avaiable in the `centos:7` image
>     
>     ```sh
>     $ docker run -it --rm centos:7 which ls
>     exec: "which": executable file not found in $PATH
>     Error response from daemon: Cannot start container f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System error: exec: "which": executable file not found in $PATH
>     ```
>     
>     To get it one need to run "yum install which".
> 
> haosdent huang wrote:
>     LoL, seems we should focus on `shasum` and `sha512sum ` command rather than `which`.
> 
> Jie Yu wrote:
>     OK, sounds good to me. (BTW, we can implement our own os::which which uses os::envirionment and os::exists).

FYI: This topic came up a few times, so I filed this JIRA to track:
https://issues.apache.org/jira/browse/MESOS-4576


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 31, 2016, 10:21 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2016, 10:21 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by haosdent huang <ha...@gmail.com>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
>     I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
>     The command "which" is not avaiable in the `centos:7` image
>     
>     ```sh
>     $ docker run -it --rm centos:7 which ls
>     exec: "which": executable file not found in $PATH
>     Error response from daemon: Cannot start container f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System error: exec: "which": executable file not found in $PATH
>     ```
>     
>     To get it one need to run "yum install which".

LoL, seems we should focus on `shasum` and `sha512sum ` command rather than `which`.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Jojy Varghese <jo...@mesosphere.io>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.

I thought `which` will work only if the command is in the path.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
>     I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
>     The command "which" is not avaiable in the `centos:7` image
>     
>     ```sh
>     $ docker run -it --rm centos:7 which ls
>     exec: "which": executable file not found in $PATH
>     Error response from daemon: Cannot start container f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System error: exec: "which": executable file not found in $PATH
>     ```
>     
>     To get it one need to run "yum install which".
> 
> haosdent huang wrote:
>     LoL, seems we should focus on `shasum` and `sha512sum ` command rather than `which`.

OK, sounds good to me. (BTW, we can implement our own os::which which uses os::envirionment and os::exists).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > <https://reviews.apache.org/r/43014/diff/1/?file=1227122#file1227122line172>
> >
> >     On ubuntu, we don't have sha512sum but shasum (and sha512).
> >     
> >     Here is what I am thinking:
> >     1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
> >     2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.
> 
> haosdent huang wrote:
>     which ubuntu version you use, I use ubuntu 14.04. Alos could found `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
>     I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
>     The command "which" is not avaiable in the `centos:7` image
>     
>     ```sh
>     $ docker run -it --rm centos:7 which ls
>     exec: "which": executable file not found in $PATH
>     Error response from daemon: Cannot start container f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System error: exec: "which": executable file not found in $PATH
>     ```
>     
>     To get it one need to run "yum install which".
> 
> haosdent huang wrote:
>     LoL, seems we should focus on `shasum` and `sha512sum ` command rather than `which`.
> 
> Jie Yu wrote:
>     OK, sounds good to me. (BTW, we can implement our own os::which which uses os::envirionment and os::exists).
> 
> Joseph Wu wrote:
>     FYI: This topic came up a few times, so I filed this JIRA to track:
>     https://issues.apache.org/jira/browse/MESOS-4576

Thanks Joseph!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------


On Jan. 31, 2016, 6:21 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
-----------------------------------------------------------




src/common/command_utils.cpp (line 172)
<https://reviews.apache.org/r/43014/#comment178195>

    On ubuntu, we don't have sha512sum but shasum (and sha512).
    
    Here is what I am thinking:
    1) we need to introduce another command util 'which' that searches PATH and returns the full path to the command (just shelling out to 'which' command).
    2) Then, we use 'which' to check for shasum, sha512sum, etc., and then use the one that's available.


- Jie Yu


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117149
-----------------------------------------------------------


Fix it, then Ship it!





src/common/command_utils.cpp (line 188)
<https://reviews.apache.org/r/43014/#comment178239>

    This is problematic to me because 'cmd' will go out of scope (after sha512 returns). The captured reference here will become a dangling pointer.


- Jie Yu


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117151
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43014]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 31, 2016, 6:21 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
>     https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> -------
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/
-----------------------------------------------------------

(Updated Jan. 31, 2016, 6:21 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.


Changes
-------

Address @jieyu's comment.


Bugs: MESOS-4556
    https://issues.apache.org/jira/browse/MESOS-4556


Repository: mesos


Description
-------

Fix ShasumTest.SHA512SimpleFile failed on centos7.


Diffs (updated)
-----

  src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
  src/tests/common/command_utils_tests.cpp e81c724fc28717f5cb1849d75a066b6da713cd44 

Diff: https://reviews.apache.org/r/43014/diff/


Testing
-------

# check in CentOS 7.
sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"


Thanks,

haosdent huang