You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by gm...@apache.org on 2021/04/16 19:14:15 UTC

[qpid-dispatch] branch main updated: DISPATCH-2034: Search for the existence of a specific incoming window in all the lines with a @begin frame, not just the first line. This closes #1131.

This is an automated email from the ASF dual-hosted git repository.

gmurthy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/main by this push:
     new 98821b4  DISPATCH-2034: Search for the existence of a specific incoming window in all the lines with a @begin frame, not just the first line. This closes #1131.
98821b4 is described below

commit 98821b495b9c50b9c2f3003959d98aa3d13b51a6
Author: Ganesh Murthy <gm...@apache.org>
AuthorDate: Fri Apr 16 13:04:41 2021 -0400

    DISPATCH-2034: Search for the existence of a specific incoming window in all the lines with a @begin frame, not just the first line. This closes #1131.
---
 tests/system_tests_protocol_settings.py | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/system_tests_protocol_settings.py b/tests/system_tests_protocol_settings.py
index 640d533..8466d52 100644
--- a/tests/system_tests_protocol_settings.py
+++ b/tests/system_tests_protocol_settings.py
@@ -392,7 +392,17 @@ class ConnectorSettingsNondefaultTest(TestCase):
             self.assertIn(' channel-max=19,', open_lines[0])
             begin_lines = [s for s in log_lines if "<- @begin" in s]
             # nondefaults
-            self.assertIn(" incoming-window=10,", begin_lines[0])
+            SEARCH_STRING = " incoming-window=10,"
+            # Sometimes, the begin frame we are looking for might not be
+            # the first in the list. We just need to make sure that
+            # it is somewhere in the list
+            line_found = False
+            for begin_line in begin_lines:
+                if SEARCH_STRING in begin_line:
+                    line_found = True
+                    break
+
+            self.assertTrue(line_found)
 
 
 if __name__ == '__main__':

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org