[GitHub] [phoenix] richardantal commented on a change in pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

[GitBox <gi...@apache.org>]

richardantal commented on a change in pull request #933:
URL: https://github.com/apache/phoenix/pull/933#discussion_r510010055



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/StoreNullsIT.java
##########
@@ -76,6 +81,15 @@
     private final String ddlFormat;
     
     private String dataTableName;
+
+    // In this class we depend on the major compaction to be done instantly
+    // so wo are overwriting the PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY to 0
+    @BeforeClass

Review comment:
       My change in TestUtil solves the hanging tests, because there we waited until a put and delete is deleted, which never happened because they were just done before calling the major compaction with a PHOENIX_MAX_LOOKBACK_AGE of an hour.
   In StoreNullsIT in testDeletes, we upsert a line into a table, delete it run the major compaction.
   Then open a historical connection after the upsert but before the delete, previously when PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY was set to 0 we could not read back the data, but if it is set to an hour, the major compaction will not delete that. So the test would fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org