[GitHub] [incubator-openwhisk-devtools] alvarolopez commented on a change in pull request #263: Redirect controller logs to correct location

[GitBox <gi...@apache.org>]

alvarolopez commented on a change in pull request #263: Redirect controller logs to correct location
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/263#discussion_r289286541
 
 

 ##########
 File path: docker-compose/docker-compose.yml
 ##########
 @@ -40,7 +40,7 @@ services:
   # WHISK CONTROLLER
   controller:
     image: ${DOCKER_IMAGE_PREFIX:-openwhisk}/controller
-    command: /bin/sh -c "exec /init.sh 0 >> /home/owuser/controller-local_logs.log 2>&1"
+    command: /bin/sh -c "exec /init.sh 0 >> /logs/controller-local_logs.log 2>&1"
 
 Review comment:
   Yes, I think that the process has permissions to write under `/logs` as, at least in my deployment from docker-compose, is running as root.
   
   Redirecting them to `/logs` is consistent with the invoker logs being there as well (as in https://github.com/apache/incubator-openwhisk-devtools/pull/263/commits/9cf4541dc937bafb1ee7246b7a5e8aa342fd4436#diff-cb44929492b826b5b16656db6a5a26a4R85). I'd rather redirect logs inside the container to the same location, being it `/logs` or `/home/owuser`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services