You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/17 17:09:27 UTC
[GitHub] [incubator-superset] bkyryliuk opened a new pull request #10939: fix: allow empty observations in alerting [WIP]
bkyryliuk opened a new pull request #10939:
URL: https://github.com/apache/incubator-superset/pull/10939
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10939: fix: allow empty observations in alerting [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10939:
URL: https://github.com/apache/incubator-superset/pull/10939#issuecomment-694394457
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=h1) Report
> Merging [#10939](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8735a14ea7ebab5add97c9bdf9685063b5cd01f6?el=desc) will **increase** coverage by `7.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10939 +/- ##
==========================================
+ Coverage 65.79% 73.15% +7.35%
==========================================
Files 815 433 -382
Lines 38335 14205 -24130
Branches 3578 3578
==========================================
- Hits 25224 10392 -14832
+ Misses 13007 3709 -9298
Partials 104 104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.60% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `61.75% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `81.89% <0.00%> (-0.87%)` | :arrow_down: |
| [...sions/41f6a59a61f2\_database\_options\_for\_sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80MWY2YTU5YTYxZjJfZGF0YWJhc2Vfb3B0aW9uc19mb3Jfc3FsX2xhYi5weQ==) | | |
| [...s/3e1b21cd94a4\_change\_owner\_to\_m2m\_relation\_on\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZTFiMjFjZDk0YTRfY2hhbmdlX293bmVyX3RvX20ybV9yZWxhdGlvbl9vbl8ucHk=) | | |
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | | |
| [superset/migrations/versions/979c03af3341\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NzljMDNhZjMzNDFfLnB5) | | |
| [...ersions/cca2f5d568c8\_add\_encrypted\_extra\_to\_dbs.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jY2EyZjVkNTY4YzhfYWRkX2VuY3J5cHRlZF9leHRyYV90b19kYnMucHk=) | | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | | |
| [...tions/versions/db527d8c4c78\_add\_db\_verbose\_name.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kYjUyN2Q4YzRjNzhfYWRkX2RiX3ZlcmJvc2VfbmFtZS5weQ==) | | |
| [...dding\_unique\_constraint\_on\_dashboard\_slices\_tbl.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xOTAxODg5Mzg1ODJfYWRkaW5nX3VuaXF1ZV9jb25zdHJhaW50X29uX2Rhc2hib2FyZF9zbGljZXNfdGJsLnB5) | | |
| [superset/migrations/versions/8b70aa3d0f87\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84YjcwYWEzZDBmODdfLnB5) | | |
| ... and [372 more](https://codecov.io/gh/apache/incubator-superset/pull/10939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=footer). Last update [8735a14...731ab54](https://codecov.io/gh/apache/incubator-superset/pull/10939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #10939: fix: allow empty observations in alerting
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #10939:
URL: https://github.com/apache/incubator-superset/pull/10939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #10939: fix: allow empty observations in alerting
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #10939:
URL: https://github.com/apache/incubator-superset/pull/10939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org