You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/09/01 00:17:15 UTC
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/50
Couchdb 2244 admin rights
- Enable access on replication for non-admins: this depended on access to `tasks` before
- Do not limit access for documents to admins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-2244--admin-rights
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit a2338c379168d5c8d3417ceeefc5e3b6937b436c
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-08-31T20:58:39Z
Convert tabs to spaces, remove trailing whitespaces
commit 3b6dd3ba0bec64c2de51adcd7a16fdebb879d613
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-08-31T22:12:32Z
Enable access on replication for non-admins
COUCHDB-2244
commit 2331ef29a02070b17a42e22d56718791349cdfb1
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-08-31T22:16:07Z
Do not limit access for documents to admins
COUCHDB-2244
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54047413
Hi @robertkowalski, I just need to understand this a little more. Why would we want anyone other than admins to view replication? Also don't we need some sort of security on a database pagem, so instead of `_admin` why not make it `_reader`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54047622
@garrensmith because every user may run replication thought API? False security will only annoy and harm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003658
my devserver crashes when i try to enter a database name:
```
Running "watch" task
Waiting...
Fatal error: socket hang up
```
but when i am lucky and it does not crash, it works for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003403
should work now! sorry!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003291
```
Running "clean:release" (clean) task
Cleaning "dist/"...OK
Cleaning "app/load_addons.js"...OK
Running "clean:watch" (clean) task
Running "get_deps:default" (get_deps) task
Fetching external dependencies
0 remote dependencies
0 local dependencies
Running "gen_load_addons:default" (gen_load_addons) task
Running "gen_initialize:couchapp" (gen_initialize) task
Running "jshint:all" (jshint) task
Linting app/addons/replication/route.js ...ERROR
[L46:C18] W117: 'isUserAdmin' is not defined.
isAdmin: isUserAdmin
Warning: Task "jshint:all" failed. Use --force to continue.
Aborted due to warnings.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003593
@robertkowalski yes, just wanted to report that anonymous user aren't able to run replications - button does nothing and with no errors or notices about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb-2244 Document admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003673
btw you'd actually fixed COUCHDB-2211, but COUCHDB-2244 and COUCHDB-2014 are get eventually fixed too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003481
wow, you are too fast :) also fixed that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003341
On replication page:
```
02:24:32.086 TypeError: this.status is undefined require.js:36
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003712
brb, fixing the devserver ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54079505
Ok thanks for clearing that up. I like what you doing here but I think this
PR needs to be split up into the replication fix, the proxy addition and
the documents changes.
On Monday, September 1, 2014, Robert Kowalski <no...@github.com>
wrote:
> @garrensmith <https://github.com/garrensmith> in the old futon everybody
> can view the replication page and people are able to use it - also during
> admin-party. Also in *non-* admin-party-mode users with the rights on
> specific databases should be able to replicate between them
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54079199>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003856
devserver should be more stable now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#discussion_r16937514
--- Diff: app/core/couchdbSession.js ---
@@ -27,6 +27,11 @@ function (FauxtonAPI) {
};
},
+ isUserAdmin: function () {
--- End diff --
hm..all above you'd used `isAdmin()` function while here is `isUserAdmin`. Any difference? Not a typo? May be use the same naming for consistency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003319
not actual any more, that's for update (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003519
not my day, will have to fix the replication itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb-2244 Document admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54079857
done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54079199
@garrensmith in the old futon everybody can view the replication page and people are able to use it - also during admin-party. Also in **non-** admin-party-mode users with the rights on specific databases should be able to replicate between them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54003447
Thanks, it fixed. Now anonymous user cannot see all databases list on replication page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2244 admin rights
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/50#issuecomment-54005080
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---