[jira] [Updated] (PHOENIX-2372) PhoenixResultSet.getDate(int, Calendar) causes NPE on a null value

["Josh Elser (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser updated PHOENIX-2372:
--------------------------------
    Attachment: PHOENIX-2372.001.patch

Trivial patch which short-circuits out quickly if the value is null. Test included (existing tests in DateTimeIT still passed -- didn't run the full suite).

> PhoenixResultSet.getDate(int, Calendar) causes NPE on a null value
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-2372
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2372
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.4.0, 4.5.0, 4.6.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>         Attachments: PHOENIX-2372.001.patch
>
>
> Ran a simple query through PQS:
> {code}
> select * from system.stats;
> {code}
> and got back a stack trace (trimmed for relevance)
> {noformat}
> java.lang.NullPointerException
>         at java.util.Calendar.setTime(Calendar.java:1770)
>         at org.apache.phoenix.jdbc.PhoenixResultSet.getDate(PhoenixResultSet.java:377)
>         at org.apache.calcite.avatica.jdbc.JdbcResultSet.getValue(JdbcResultSet.java:172)
>         at org.apache.calcite.avatica.jdbc.JdbcResultSet.frame(JdbcResultSet.java:142)
> {noformat}
> It looks like the {{getDate(int, Calendar)}} method on PhoenixResultSet doesn't check the value before passing it into the calendar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)