You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/07/29 11:00:48 UTC
[GitHub] zeppelin pull request #1245: ZEPPELIN-1225. Errors before the last shell com...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1245
ZEPPELIN-1225. Errors before the last shell command are ignored
What is this PR for?
The problem is that command "bash -c " will always return 0 as long as the last line of shell script run correctly. e.g the following command will run correctly without any error message.
hello
pwd
This PR will redirect stderr and stdout to the same place, and will display both the stderr and stdout to frontend just like what user see in the native shell terminal. So the output of above command will be as following
bash: hello: command not found
/Users/jzhang/github/zeppelin
What type of PR is it?
[Bug Fix]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1225
How should this be tested?
Unit test is added and also manually verify it on zeppelin notebook.
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1225-0.6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1245
----
commit 40a156e237187e839723507e6497ad7672a68530
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-29T10:56:24Z
ZEPPELIN-1225. Errors before the last shell command are ignored
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1245: ZEPPELIN-1225. Errors before the last shell com...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1245: ZEPPELIN-1225. Errors before the last shell command ar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1245
@zjffdu Thanks. LGTM and merge into branch-0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1245: ZEPPELIN-1225. Errors before the last shell command ar...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1245
@zjffdu Could you please close this PR by yourself? It was merged 4 days ago but it's not affected into master then asfgit could not close it automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1245: ZEPPELIN-1225. Errors before the last shell command ar...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1245
@Leemoonsoo this is for branch-0.6, the test fail seems irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---