You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/03/13 10:06:24 UTC
[GitHub] [pulsar] nodece opened a new pull request, #19797: [cleanup][proxy] Remove authorization config
nodece opened a new pull request, #19797:
URL: https://github.com/apache/pulsar/pull/19797
### Motivation
In https://github.com/apache/pulsar/pull/1002, authorization is no longer done by proxy, so I clean up the proxy authorization.
### Modifications
- Remove `superUserRoles`, `authorizationEnabled`, and `authorizationProvider` from the proxy config
- Update the authorization tests
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19797: [cleanup][proxy] Remove authorization config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19797:
URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1543175701
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #19797: [cleanup][proxy] Remove authorization config
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19797:
URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1479299342
Good catch! I didn't notice the proxy extensions, I can add the `@Deprecated` to the these fields and methods.
What do you think of that? @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #19797: [cleanup][proxy] Remove authorization config
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #19797: [cleanup][proxy] Remove authorization config
URL: https://github.com/apache/pulsar/pull/19797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #19797: [cleanup][proxy] Remove authorization config
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19797:
URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1478084803
> Does passing unknown key-value pairs cause fatal? I'm afraid that users will continue using existing conf file that contains now removed key value pair.
No impact. Users can continue the old config, the proxy didn't use these config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #19797: [cleanup][proxy] Remove authorization config
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19797:
URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1481892432
I thought that might work, but @eolivelli thinks we should keep it around. It sounds like the kind of decision to make on the mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org