[GitHub] [kafka] cmccabe commented on a diff in pull request #13183: KAFKA-14668 Avoid unnecessary UMR during ZK migration

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1093787328


##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -106,6 +109,13 @@ public void shutdown() throws InterruptedException {
         eventQueue.close();
     }
 
+    // Visible for testing
+    Future<MigrationState> migrationState() {

Review Comment:
   Would be better as if the return type were `CompletableFuture`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org