You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2008/12/06 02:25:44 UTC

[jira] Created: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
--------------------------------------------------------------------------------

                 Key: HADOOP-4796
                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
             Project: Hadoop Core
          Issue Type: Bug
         Environment: Redhat EL 5, Java 6
            Reporter: Eric Yang
            Assignee: Eric Yang


Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated HADOOP-4796:
------------------------------

    Attachment: HADOOP-4796.diff

Chukwa test cases were divided into 5 categories:

chunk
input tools
agent
collector
demux
database

There used to be test target for each components.  Instead, this is changed to the same structure as Hadoop.  Unit test can be executed like:

ant -Dtestcase=TestChunk test
ant -Dtest.include=adaptor/Test* test

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>         Attachments: HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-4796:
------------------------------------

    Release Note:   (was: Change component unit test targets from "ant test-agent" to "ant -Dtestcase=TestAgent test". )

No release note for "just a bug."

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build, contrib/chukwa
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated HADOOP-4796:
------------------------------

    Release Note: 
Improvement in HADOOP-4796:

Change component unit test targets from "ant test-agent" to "ant -Dtestcase=TestAgent test". 
          Status: Patch Available  (was: Open)

Remove legacy test targets, test components are called dynamically.

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>         Attachments: HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654832#action_12654832 ] 

Hudson commented on HADOOP-4796:
--------------------------------

Integrated in Hadoop-trunk #683 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/683/])
    

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build, contrib/chukwa
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated HADOOP-4796:
------------------------------

    Status: Patch Available  (was: Open)

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4796:
----------------------------------

        Fix Version/s: 0.20.0
    Affects Version/s: 0.20.0
               Status: Open  (was: Patch Available)

The patch looks good, but the following should be omitted:
{noformat}
+              <!-- FIXME: Fix incompleted test cases -->
+              <exclude name="**/TestDemux.java"/>
+              <exclude name="**/TestAgentCollector.java"/>
+              <exclude name="**/TestChukwaAppender.java"/>
{noformat}

Assuming the tests themselves are invalid, they should be removed from the distribution and added back in a separate issue once they're fixed. Removing them as part of this patch would make sense.

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4796:
----------------------------------

      Resolution: Fixed
    Release Note: Change component unit test targets from "ant test-agent" to "ant -Dtestcase=TestAgent test".   (was: Improvement in HADOOP-4796:

Change component unit test targets from "ant test-agent" to "ant -Dtestcase=TestAgent test". )
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

+1 Looks good

I just committed this. Thanks, Eric

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated HADOOP-4796:
------------------------------

    Attachment: HADOOP-4796-2.patch

Same patch as above plus:

Removed incompleted test cases for:

- Agent to Collector communication test
- Demux test (can't run without test data)
- Log4j appender test case

Removed unused library:

ant.jar, ant-README.txt, ant-LICENSE.txt

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654276#action_12654276 ] 

Eric Yang commented on HADOOP-4796:
-----------------------------------

Thank you Chris. :)

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build, contrib/chukwa
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4796) Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4796:
----------------------------------

    Component/s: contrib/chukwa
                 build

> Test target for chukwa build.xml needs to comply to hadoop build.xml test suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build, contrib/chukwa
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796-2.patch, HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases.  The build.xml needs to be polished to avoid testing the wrong test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.