You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by bo...@apache.org on 2022/11/09 07:04:48 UTC
[pulsar] 02/02: Fix metadata cache inconsistency on do refresh (#14283)
This is an automated email from the ASF dual-hosted git repository.
bogong pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit e9d87fa09d9710c11dea8f1a1f5968c8f48fa138
Author: Kai Wang <kw...@streamnative.io>
AuthorDate: Tue Feb 15 18:42:13 2022 +0800
Fix metadata cache inconsistency on do refresh (#14283)
(cherry picked from commit 2e16b4341682083a329b63ffaae6d2df2eeec3c5)
---
.../apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
index 2a4d6bb406d..2cbe9a6dc19 100644
--- a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
+++ b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
@@ -266,10 +266,7 @@ public class MetadataCacheImpl<T> implements MetadataCache<T>, Consumer<Notifica
@Override
public void refresh(String path) {
// Refresh object of path if only it is cached before.
- if (objCache.getIfPresent(path) != null) {
- objCache.synchronous().invalidate(path);
- objCache.synchronous().refresh(path);
- }
+ objCache.asMap().computeIfPresent(path, (oldKey, oldValue) -> readValueFromStore(path));
}
@VisibleForTesting
@@ -283,11 +280,7 @@ public class MetadataCacheImpl<T> implements MetadataCache<T>, Consumer<Notifica
switch (t.getType()) {
case Created:
case Modified:
- if (objCache.synchronous().getIfPresent(path) != null) {
- // Trigger background refresh of the cached item, but before make sure
- // to invalidate the entry so that we won't serve a stale cached version
- refresh(path);
- }
+ refresh(path);
break;
case Deleted: