You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "zrhoffman (via GitHub)" <gi...@apache.org> on 2023/09/11 21:19:21 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7795: Update CDN in a Box enroller to use TO API v5

zrhoffman opened a new pull request, #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795

   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   This PR makes the CDN in a Box enroller use Traffic Ops API version 5.
   
   This PR also removes `v5` from some API v5 TO client method names.
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - CDN in a Box - Enroller
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your PR.
   If your PR has tests (and most should), provide the steps needed to run the tests.
   If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
   Verify that GitHub Actions pass
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
   Examples:
   - 5.1.2
   - 5.1.3 (RC1)
    -->
   
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   -  [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 merged PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#issuecomment-1714596449

   ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7795](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f801c5d) into [master](https://app.codecov.io/gh/apache/trafficcontrol/commit/75ec56fa1bc4cf9c9e9ba54bde92197d4381649d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (75ec56f) will **decrease** coverage by `27.02%`.
   > Report is 132 commits behind head on master.
   > The diff coverage is `38.59%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #7795       +/-   ##
   =============================================
   - Coverage     65.05%   38.04%   -27.02%     
     Complexity       98       98               
   =============================================
     Files           314      424      +110     
     Lines         12365    34109    +21744     
     Branches        907       90      -817     
   =============================================
   + Hits           8044    12976     +4932     
   - Misses         3968    19954    +15986     
   - Partials        353     1179      +826     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [golib_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.63% <53.70%> (?)` | |
   | [grove_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.02% <ø> (?)` | |
   | [t3c_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `5.96% <2.74%> (?)` | |
   | [traffic_monitor_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.44% <ø> (?)` | |
   | [traffic_portal_v2](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [traffic_stats_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `10.78% <ø> (?)` | |
   | [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.17% <38.59%> (-41.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files Changed](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [cache-config/t3c-apply/config/config.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1hcHBseS9jb25maWcvY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | |
   | [cache-config/t3c-apply/torequest/cmd.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1hcHBseS90b3JlcXVlc3QvY21kLmdv) | `0.00% <0.00%> (ø)` | |
   | [cache-config/t3c-check-refs/t3c-check-refs.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1jaGVjay1yZWZzL3QzYy1jaGVjay1yZWZzLmdv) | `1.78% <0.00%> (ø)` | |
   | [cache-config/t3c-generate/cfgfile/varnish.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1nZW5lcmF0ZS9jZmdmaWxlL3Zhcm5pc2guZ28=) | `0.00% <0.00%> (ø)` | |
   | [cache-config/t3c-generate/config/config.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1nZW5lcmF0ZS9jb25maWcvY29uZmlnLmdv) | `0.81% <0.00%> (-0.08%)` | :arrow_down: |
   | [cache-config/t3c-generate/t3c-generate.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2FjaGUtY29uZmlnL3QzYy1nZW5lcmF0ZS90M2MtZ2VuZXJhdGUuZ28=) | `0.00% <ø> (ø)` | |
   | [lib/go-atscfg/parentabstraction.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2dvLWF0c2NmZy9wYXJlbnRhYnN0cmFjdGlvbi5nbw==) | `79.47% <ø> (ø)` | |
   | [lib/go-tc/cdns.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2dvLXRjL2NkbnMuZ28=) | `0.00% <ø> (ø)` | |
   | [lib/go-tc/deliveryservice\_servers.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2dvLXRjL2RlbGl2ZXJ5c2VydmljZV9zZXJ2ZXJzLmdv) | `0.00% <0.00%> (ø)` | |
   | [lib/go-tc/federation\_resolver.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2dvLXRjL2ZlZGVyYXRpb25fcmVzb2x2ZXIuZ28=) | `45.45% <0.00%> (ø)` | |
   | ... and [12 more](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [311 files with indirect coverage changes](https://app.codecov.io/gh/apache/trafficcontrol/pull/7795/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1322242574


##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -318,10 +318,10 @@ func enrollDeliveryServiceServer(toSession *session, r io.Reader) error {
 		if len(servers.Response) == 0 {
 			return errors.New("no server with hostName " + sn)
 		}
-		if servers.Response[0].ID == nil {
-			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with null or undefined ID", sn)
+		if servers.Response[0].ID < 1 {
+			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with non-positive ID", sn)

Review Comment:
   I think you should just get rid of this check instead of "fixing" it. It's not actually stated anywhere that all of our IDs will always be positive numbers, that's an implementation detail of an implementation detail. Clients needn't be expected to handle that.
   
   Besides, the purpose of the check was to prevent a segmentation fault later during dereference, not to double-check that data received is valid.



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -361,21 +361,21 @@ func enrollDivision(toSession *session, r io.Reader) error {
 
 func enrollOrigin(toSession *session, r io.Reader) error {
 	dec := json.NewDecoder(r)
-	var s tc.Origin
+	var s tc.OriginV5
 	err := dec.Decode(&s)
 	if err != nil {
 		log.Infof("error decoding Origin: %v", err)
 		return err
 	}
-	if s.Name == nil {
+	if s.Name == "" {

Review Comment:
   same as above, but with less gusto



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -827,7 +827,7 @@ func enrollFederation(toSession *session, r io.Reader) error {
 				return err
 			}
 			deliveryService := deliveryServices.Response[0]
-			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == nil {
+			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == "" {

Review Comment:
   same as directly above



##########
infrastructure/cdn-in-a-box/enroller/Dockerfile:
##########
@@ -40,6 +40,7 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 COPY ./vendor/ /go/src/github.com/apache/trafficcontrol/vendor/
 COPY ./traffic_ops/toclientlib/ /go/src/github.com/apache/trafficcontrol/traffic_ops/toclientlib/
 COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/

Review Comment:
   do we still need the v4 client for something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1323293861


##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -827,7 +827,7 @@ func enrollFederation(toSession *session, r io.Reader) error {
 				return err
 			}
 			deliveryService := deliveryServices.Response[0]
-			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == nil {
+			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == "" {

Review Comment:
   Removed in 6268f0aaf



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -361,21 +361,21 @@ func enrollDivision(toSession *session, r io.Reader) error {
 
 func enrollOrigin(toSession *session, r io.Reader) error {
 	dec := json.NewDecoder(r)
-	var s tc.Origin
+	var s tc.OriginV5
 	err := dec.Decode(&s)
 	if err != nil {
 		log.Infof("error decoding Origin: %v", err)
 		return err
 	}
-	if s.Name == nil {
+	if s.Name == "" {

Review Comment:
   > same as above, but with less gusto
   
   Removed in 6268f0aaf2



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -361,21 +361,21 @@ func enrollDivision(toSession *session, r io.Reader) error {
 
 func enrollOrigin(toSession *session, r io.Reader) error {
 	dec := json.NewDecoder(r)
-	var s tc.Origin
+	var s tc.OriginV5
 	err := dec.Decode(&s)
 	if err != nil {
 		log.Infof("error decoding Origin: %v", err)
 		return err
 	}
-	if s.Name == nil {
+	if s.Name == "" {

Review Comment:
   > same as above, but with less gusto
   
   Removed in 6268f0aa



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1323266335


##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -318,10 +318,10 @@ func enrollDeliveryServiceServer(toSession *session, r io.Reader) error {
 		if len(servers.Response) == 0 {
 			return errors.New("no server with hostName " + sn)
 		}
-		if servers.Response[0].ID == nil {
-			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with null or undefined ID", sn)
+		if servers.Response[0].ID < 1 {
+			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with non-positive ID", sn)

Review Comment:
   > I think you should just get rid of this check instead of "fixing" it.
   
   Removed in 6268f0aaf



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -361,21 +361,21 @@ func enrollDivision(toSession *session, r io.Reader) error {
 
 func enrollOrigin(toSession *session, r io.Reader) error {
 	dec := json.NewDecoder(r)
-	var s tc.Origin
+	var s tc.OriginV5
 	err := dec.Decode(&s)
 	if err != nil {
 		log.Infof("error decoding Origin: %v", err)
 		return err
 	}
-	if s.Name == nil {
+	if s.Name == "" {

Review Comment:
   > same as above, but with less gusto
   
   Removed in 6268f0aaf



##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -827,7 +827,7 @@ func enrollFederation(toSession *session, r io.Reader) error {
 				return err
 			}
 			deliveryService := deliveryServices.Response[0]
-			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == nil {
+			if deliveryService.CDNName == nil || deliveryService.ID == nil || deliveryService.XMLID == "" {

Review Comment:
   Removed in 6268f0aaf2



##########
infrastructure/cdn-in-a-box/enroller/Dockerfile:
##########
@@ -40,6 +40,7 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 COPY ./vendor/ /go/src/github.com/apache/trafficcontrol/vendor/
 COPY ./traffic_ops/toclientlib/ /go/src/github.com/apache/trafficcontrol/traffic_ops/toclientlib/
 COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/

Review Comment:
   > do we still need the v4 client for something?
   
   Yes. `github.com/apache/trafficcontrol/lib/go-tc/totest`, the library used for the t3c integration tests, uses API v4. Once #7774 is merged, it will use API v5 instead and this line can be removed (or even in #7774 itself if #7795 gets merged first).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#issuecomment-1716637267

   I can't tell why this would fail the tests just by looking at it, but they seem to be failing consistently


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1323266335


##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -318,10 +318,10 @@ func enrollDeliveryServiceServer(toSession *session, r io.Reader) error {
 		if len(servers.Response) == 0 {
 			return errors.New("no server with hostName " + sn)
 		}
-		if servers.Response[0].ID == nil {
-			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with null or undefined ID", sn)
+		if servers.Response[0].ID < 1 {
+			return fmt.Errorf("Traffic Ops gave back a representation for server '%s' with non-positive ID", sn)

Review Comment:
   > I think you should just get rid of this check instead of "fixing" it.
   
   Removed in 6268f0aa



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7795: Update CDN in a Box enroller to use TO API v5

Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#issuecomment-1716051056

   Rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org