You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/01 08:18:38 UTC

[GitHub] [maven-release] Captain-P-Goldfish commented on a diff in pull request #154: [MRELEASE-1107] Respect line separator also on release:prepare

Captain-P-Goldfish commented on code in PR #154:
URL: https://github.com/apache/maven-release/pull/154#discussion_r985069185


##########
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java:
##########
@@ -455,7 +454,12 @@ private String getLineSeparatorFromPom()
     {
         char current;
         String lineSeparator = "";
-        try ( InputStream is = new FileInputStream( this.project.getFile() ) )
+        File releasePom = this.project.getFile();
+        if (releasePom == null)

Review Comment:
   not during prepare but it was null within some tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org