You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by John Peacock <jo...@havurah-software.org> on 2007/10/24 01:53:53 UTC
[PATCH] Issue 2646: Perl bindings for more client functions
I've upgraded and reviewed Mattias' patch to Client.pm. I've got another one
brewing for Repos.pm that should come along shortly. If I can get a Approved
by: for these, I'll apply to trunk (before redoing the perl-bindings-improvement
branch). I've actually got a script to generate the list of XS-wrapped, but
such automation will have to wait until I have some more tuits (round or octagonal).
John
[[[
Make many functions added since version 1.0 in the Client API visible
to users of the Perl bindings. They are already swig-wrapped, just not
exported. (issue 2646)
* subversion/bindings/swig/perl/native/Client.pm
Export more API functions, and refactor to avoid unnecessary repetition.
Patch by: Mattias Engdegård <ma...@virtutech.se>
me
]]]
=== Client.pm
==================================================================
--- Client.pm (revision 27320)
+++ Client.pm (local)
@@ -5,12 +5,33 @@
use SVN::Wc;
package SVN::Client;
-use SVN::Base qw(Client svn_client_ checkout update switch add mkdir delete
- commit status log blame diff merge cleanup relocate
- revert resolved copy move revprop_set propset
- proplist revvprop_list export ls cat import propget
- uuid_from_url uuid_from_path url_from_path revprop_get
- revprop_list info);
+my @_all_fns;
+BEGIN {
+ @_all_fns =
+ qw( version diff_summarize_dup create_context checkout3
+ checkout2 checkout update3 update2 update switch2 switch
+ add4 add3 add2 add mkdir3 mkdir2 mkdir delete3 delete2
+ delete import3 import2 import commit4 commit3 commit2
+ commit status3 status2 status log4 log3 log2 log blame4
+ blame3 blame2 blame diff4 diff3 diff2 diff diff_peg4
+ diff_peg3 diff_peg2 diff_peg diff_summarize2
+ diff_summarize diff_summarize_peg2 diff_summarize_peg
+ merge3 merge2 merge merge_peg3 merge_peg2 merge_peg
+ cleanup relocate revert2 revert resolved resolved2 copy4
+ copy3 copy2 copy move5 move4 move3 move2 move propset3
+ propset2 propset revprop_set propget4 propget3 propget2
+ propget revprop_get proplist3 proplist2 proplist
+ revprop_list export4 export3 export2 export list2 list
+ ls3 ls2 ls cat2 cat add_to_changelist
+ remove_from_changelist lock unlock info2 info
+ url_from_path uuid_from_url uuid_from_path open_ra_session
+ invoke_blame_receiver2 invoke_blame_receiver
+ invoke_diff_summarize_func
+ );
+
+ require SVN::Base;
+ import SVN::Base (qw(Client svn_client_), @_all_fns);
+}
=head1 NAME
@@ -820,13 +841,7 @@
# import methods into our name space and wrap them in a closure
# to support method calling style $ctx->log()
-foreach my $function (qw(checkout update switch add mkdir delete commit
- status log blame diff merge cleanup relocate
- revert resolved copy move revprop_set propset
- proplist revvprop_list export ls cat import
- propget uuid_from_url uuid_from_path
- url_from_path revprop_get revprop_list
- info))
+foreach my $function (@_all_fns)
{
no strict 'refs';
my $real_function = \&{"SVN::_Client::svn_client_$function"};
@@ -1301,6 +1316,8 @@
=item $info->prejfile()
+=back
+
=cut
package _p_svn_client_commit_info_t;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue 2646: Perl bindings for more repos functions
Posted by John Peacock <jo...@havurah-software.org>.
John Peacock wrote:
> Second patch by Troy Curtis Jr, revised and extended (attached this time).
>
>
> [[[
> Make many functions added since version 1.0 in the Client API visible
> to users of the Perl bindings. They are already swig-wrapped, just not
> exported. (issue 2646)
>
> * subversion/bindings/swig/perl/native/Repos.pm:
> Export more API functions.
> (POD Documentation): Added entries documenting dump_fs2 and load_fs2.
>
> Patch by: Troy Curtis Jr <tr...@gmail.com>
> me
> ]]]
>
*PING* Can I get a +1 to commit this to trunk???
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Issue 2646: Perl bindings for more repos functions
Posted by John Peacock <jo...@havurah-software.org>.
Second patch by Troy Curtis Jr, revised and extended (attached this time).
[[[
Make many functions added since version 1.0 in the Client API visible
to users of the Perl bindings. They are already swig-wrapped, just not
exported. (issue 2646)
* subversion/bindings/swig/perl/native/Repos.pm:
Export more API functions.
(POD Documentation): Added entries documenting dump_fs2 and load_fs2.
Patch by: Troy Curtis Jr <tr...@gmail.com>
me
]]]
John
Re: [PATCH] Issue 2646: Perl bindings for more client functions
Posted by John Peacock <jo...@havurah-software.org>.
Daniel Rall wrote:
> I reviewed and +1'd both patches a few days back, but just switched
> ISPs and lost a bunch of email. Please do commit them.
I hear and obey. Thanks!
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue 2646: Perl bindings for more client functions
Posted by Daniel Rall <dl...@collab.net>.
On Mon, 29 Oct 2007, John Peacock wrote:
> John Peacock wrote:
> > I've upgraded and reviewed Mattias' patch to Client.pm. I've got another one
> > brewing for Repos.pm that should come along shortly. If I can get a Approved
> > by: for these, I'll apply to trunk (before redoing the perl-bindings-improvement
> > branch).
>
> *PING* Can I get a +1 to commit this to trunk???
I reviewed and +1'd both patches a few days back, but just switched
ISPs and lost a bunch of email. Please do commit them.
Re: [PATCH] Issue 2646: Perl bindings for more client functions
Posted by John Peacock <jo...@havurah-software.org>.
John Peacock wrote:
> I've upgraded and reviewed Mattias' patch to Client.pm. I've got another one
> brewing for Repos.pm that should come along shortly. If I can get a Approved
> by: for these, I'll apply to trunk (before redoing the perl-bindings-improvement
> branch).
*PING* Can I get a +1 to commit this to trunk???
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org