You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/04/08 03:50:06 UTC
[Impala-ASF-CR] Bump Kudu Java version.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9935
Change subject: Bump Kudu Java version.
......................................................................
Bump Kudu Java version.
For consistency, use a more updated version of the Kudu jar in
minicluster_profile=3, which now has decimal support in it.
Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/9935/2
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2257/
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 18:22:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 17:03:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Grant Henke, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9935
to look at the new patch set (#3).
Change subject: Bump Kudu Java version.
......................................................................
Bump Kudu Java version.
For consistency, use a more updated version of the Kudu jar
in minicluster_profile=3, which now has decimal support in it.
For the =2 profile, bump up to a more recent Kudu version.
I will prepare a separate change for 2.x.
Cherry-picks: not for 2.x
Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/9935/3
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9935/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/9935/2/bin/impala-config.sh@201
PS2, Line 201: export KUDU_JAVA_VERSION=1.7.0-cdh5.16.0-SNAPSHOT
I think this should be 1.8.0-cdh5.16.0-SNAPSHOT.
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 17:10:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Bump Kudu Java version.
For consistency, use a more updated version of the Kudu jar
in minicluster_profile=3, which now has decimal support in it.
For the =2 profile, bump up to a more recent Kudu version.
I will prepare a separate change for 2.x.
Cherry-picks: not for 2.x
Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Reviewed-on: http://gerrit.cloudera.org:8080/9935
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Grant Henke: Looks good to me, but someone else must approve
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 18:20:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 2:
https://jenkins.impala.io/job/gerrit-verify-dryrun-external/108/ ran happily.
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sun, 08 Apr 2018 03:50:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 17:38:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump Kudu Java version.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9935 )
Change subject: Bump Kudu Java version.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25f2f6c09df637d741a571ed8c21eb3612421e23
Gerrit-Change-Number: 9935
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 22:10:01 +0000
Gerrit-HasComments: No