You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/03/11 01:45:31 UTC
[kudu-CR] util: fix test compilation failures when building with gcc5
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6354
to review the following change.
Change subject: util: fix test compilation failures when building with gcc5
......................................................................
util: fix test compilation failures when building with gcc5
Both env-test and env_util-test fail to build with gcc5. The error messages
look like this:
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc: In lambda function:
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:71: error: label 'gtest_label_testnofatal_68' used but not defined
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:108: warning: label 'gtest_label_testnofatal_74' defined but not used [-Wunused-label]
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc: In member function 'virtual void kudu::env_util::EnvUtilTest_TestDiskSpaceCheck_Test::TestBody()':
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:71: error: label 'gtest_label_testnofatal_72' used but not defined
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:108: warning: label 'gtest_label_testnofatal_74' defined but not used [-Wunused-label]
src/kudu/util/CMakeFiles/env_util-test.dir/build.make:62: recipe for target 'src/kudu/util/CMakeFiles/env_util-test.dir/env_util-test.cc.o' failed
make[2]: *** [src/kudu/util/CMakeFiles/env_util-test.dir/env_util-test.cc.o] Error 1
CMakeFiles/Makefile2:17400: recipe for target 'src/kudu/util/CMakeFiles/env_util-test.dir/all' failed
make[1]: *** [src/kudu/util/CMakeFiles/env_util-test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
I thought maybe it was due to the NO_FATALS() nesting so I removed the inner
calls, but that didn't work. Removing the NO_FATALS() surrounding the
AssertEventually() calls does work, however.
Change-Id: I93b4b9a4e1d545144a0f82c0839ed6c445a7aec1
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/6354/1
--
To view, visit http://gerrit.cloudera.org:8080/6354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93b4b9a4e1d545144a0f82c0839ed6c445a7aec1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] util: fix test compilation failures when building with gcc5
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: util: fix test compilation failures when building with gcc5
......................................................................
util: fix test compilation failures when building with gcc5
Both env-test and env_util-test fail to build with gcc5. The error messages
look like this:
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc: In lambda function:
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:71: error: label 'gtest_label_testnofatal_68' used but not defined
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:108: warning: label 'gtest_label_testnofatal_74' defined but not used [-Wunused-label]
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc: In member function 'virtual void kudu::env_util::EnvUtilTest_TestDiskSpaceCheck_Test::TestBody()':
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:71: error: label 'gtest_label_testnofatal_72' used but not defined
/home/adar/Source/kudu/src/kudu/util/env_util-test.cc:66:108: warning: label 'gtest_label_testnofatal_74' defined but not used [-Wunused-label]
src/kudu/util/CMakeFiles/env_util-test.dir/build.make:62: recipe for target 'src/kudu/util/CMakeFiles/env_util-test.dir/env_util-test.cc.o' failed
make[2]: *** [src/kudu/util/CMakeFiles/env_util-test.dir/env_util-test.cc.o] Error 1
CMakeFiles/Makefile2:17400: recipe for target 'src/kudu/util/CMakeFiles/env_util-test.dir/all' failed
make[1]: *** [src/kudu/util/CMakeFiles/env_util-test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
I thought maybe it was due to the NO_FATALS() nesting so I removed the inner
calls, but that didn't work. Removing the NO_FATALS() surrounding the
AssertEventually() calls does work, however.
Change-Id: I93b4b9a4e1d545144a0f82c0839ed6c445a7aec1
Reviewed-on: http://gerrit.cloudera.org:8080/6354
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93b4b9a4e1d545144a0f82c0839ed6c445a7aec1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] util: fix test compilation failures when building with gcc5
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: util: fix test compilation failures when building with gcc5
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b4b9a4e1d545144a0f82c0839ed6c445a7aec1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No