[GitHub] [incubator-druid] jihoonson opened a new pull request #7520: Fix encoded taskId check in chatHandlerResource

[GitBox <gi...@apache.org>]

jihoonson opened a new pull request #7520: Fix encoded taskId check in chatHandlerResource
URL: https://github.com/apache/incubator-druid/pull/7520
 
 
   `ChatHandler` is an interface to provide RESTful APIs and some tasks are using it to communicate with other Druid modules. When a chatHanlder API is called, `ChatHandlerResource` checks the current running task is the expected callee. Before 0.14, it checked `taskId` as it is, but after https://github.com/apache/incubator-druid/pull/6761, it encodes `taskId` before comparing it. This breaks the backwards compatibility, especially when middleManagers of different versions are running in the same cluster. If `taskId` doesn't match, `ChatHandlerResource` returns null which just returns `NOT_FOUND` error (404) with no message which makes hard to debug.
   
   This PR fixes the compatibility issue and improves `ChatHandlerResource` to return `BAD_REQUEST` error with a proper message when `taskId` doesn't match.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org