You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/25 10:24:43 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5160: Fix configuration of ntp server list in systemVMs

Pearl1594 opened a new pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160


   ### Description
   
   This PR configures the /etc/ntp.conf file with the list of servers set against the global setting - 'ntp.server.list' 
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Set the global setting value for ntp.server.list and recreated the SSVM - logged into the SSVM and verified the following:
   - the /etc/ntp.conf file has the list of ntp servers configured
   - Also verified by using `ntpq -p`
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868418506


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868473829


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868400619


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868473182


   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868482610


   as discussed with @Pearl1594 , it would be better to use systemd-timesyncd instead of ntp in 4.16.0.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#discussion_r658670099



##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -567,14 +567,12 @@ setup_ntp() {
     if [ -f $NTP_CONF_FILE ]
     then
         IFS=',' read -a server_list <<< "$NTP_SERVER_LIST"
+        sed -i "/^server /d" $NTP_CONF_FILE
         for (( iterator=${#server_list[@]}-1 ; iterator>=0 ; iterator-- ))
         do
             server=$(echo ${server_list[iterator]} | tr -d '\r')
             PATTERN="server $server"
-            if grep -q "^$PATTERN$" $NTP_CONF_FILE ; then
-                sed -i "/^$PATTERN$/d" $NTP_CONF_FILE
-            fi
-            sed -i "0,/^server/s//$PATTERN\nserver/" $NTP_CONF_FILE
+            sed -i "0,/^#server/s//$PATTERN\n#server/" $NTP_CONF_FILE

Review comment:
       ```suggestion
               sed -i "0,/^#server/s//#server\n$PATTERN\n/" $NTP_CONF_FILE
   ```
   no biggy, but this seems a little neater comment pertaining to the line below and not above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868927831


   <b>Trillian test result (tid-1108)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46489 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5160-t1108-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3608.28 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3613.99 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.14 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.14 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.19 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 91.24 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5160: Fix configuration of ntp server list in systemVMs

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5160:
URL: https://github.com/apache/cloudstack/pull/5160#issuecomment-868401235


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org