You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/10 14:09:09 UTC

[GitHub] [shardingsphere] cheese8 commented on a diff in pull request #17500: support is null or is not null on right

cheese8 commented on code in PR #17500:
URL: https://github.com/apache/shardingsphere/pull/17500#discussion_r869288243


##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java:
##########
@@ -109,6 +110,9 @@ private void addEncryptConditions(final Collection<EncryptCondition> encryptCond
     
     private void addEncryptConditions(final Collection<EncryptCondition> encryptConditions, final ExpressionSegment expression, final Map<String, String> expressionTableNames) {
         for (ColumnSegment each : ColumnExtractor.extract(expression)) {
+            if (nullOnRight(expression)) {

Review Comment:
   To check `IS NULL` or `IS NOT NULL` on the right of BinaryOperationExpression, if there is, `continue` to skip it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org