[jira] [Comment Edited] (HDFS-12756) Ozone: Add datanodeID to heartbeat responses and container protocol

["Nanda kumar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235414#comment-16235414 ] 

Nanda kumar edited comment on HDFS-12756 at 11/2/17 9:03 AM:
-------------------------------------------------------------

[~anu], thanks for the patch. +1, looks good to me.
Just a small query, using {{DatanodeUUID}} String will have less memory footprint on RPC calls, is there any reason for not using DatanodeIDProto instead?

NIT: XceiverClientHandler:143 Typo in distinguish


was (Author: nandakumar131):
[~anu], thanks for the patch. +1, looks good to me.
Just a small query, using {{setDatanodeUUID}} String will have less memory footprint on RPC calls, is there any reason for not using DatanodeIDProto instead?

NIT: XceiverClientHandler:143 Typo in distinguish

> Ozone: Add datanodeID to heartbeat responses and container protocol
> -------------------------------------------------------------------
>
>                 Key: HDFS-12756
>                 URL: https://issues.apache.org/jira/browse/HDFS-12756
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-12756-HDFS-7240.001.patch
>
>
> if we have datanode ID in the HBs responses and commands send to datanode, we will be able to do additional sanity checking on datanode before executing the command. This is also very helpful in creating a MiniOzoneCluster with 1000s of simulated nodes. This is needed for scale based unit tests of SCM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org