You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/13 23:04:03 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2868: Split out arrow-integration-test crate
tustvold opened a new pull request, #2868:
URL: https://github.com/apache/arrow-rs/pull/2868
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Splits out the code to support the arrow integration test JSON format as requested on https://github.com/apache/arrow-rs/pull/2724#issuecomment-1272121381 by @maxburke
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Moves the arrow-integration-testing::util module into a crate which can be published
Renames the integration-testing directory to match the name of the crate ("arrow-integration-testing")
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2868: Split out arrow-integration-test crate
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2868:
URL: https://github.com/apache/arrow-rs/pull/2868#issuecomment-1279350592
Benchmark runs are scheduled for baseline = d67d5fb0086ee5a18bf3a148c874ccb11533044d and contender = 9c5ba92f144014011b88f8859191708c5641cf1b. 9c5ba92f144014011b88f8859191708c5641cf1b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/952778c7308c478188675d57e2d0e964...01175f79df69471498c1de8d038f175c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d808d965decd4620b0f5a26e89d01712...c29a66a25b9344e59a1cb479eb5bcef9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/385f91dde91a4af882db02987c7fd74a...ab49593466964f4ab31f81c8d44147b5/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d6221309d81d454eb10841d2180e8fe3...3d4e95e0ff47456a8134fec4d8235ab8/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2868: Split out arrow-integration-test crate
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2868:
URL: https://github.com/apache/arrow-rs/pull/2868#discussion_r996044425
##########
.github/workflows/integration.yml:
##########
@@ -30,7 +30,8 @@ on:
- arrow-data/**
- arrow-schema/**
- arrow-pyarrow-integration-testing/**
- - integration-testing/**
+ - arrow-integration-test/**
+ - arrow-integration-testing/**
Review Comment:
the similar naming is unfortunate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2868: Split out arrow-integration-test crate
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2868:
URL: https://github.com/apache/arrow-rs/pull/2868#issuecomment-1279348280
Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2868: Split out arrow-integration-test crate
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2868:
URL: https://github.com/apache/arrow-rs/pull/2868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org