You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:02:17 UTC
[GitHub] [pulsar] Pomelongan opened a new pull request, #18024: [fix][broker]update the log print content of createSubscriptions
Pomelongan opened a new pull request, #18024:
URL: https://github.com/apache/pulsar/pull/18024
### Motivation
In `org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#createSubscriptions`, when subscriptions are successfully created on the new partitions, the log print content is "successfully created new partitions", not "successfully created subscriptions on new partitions".
### Modifications
In `org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#createSubscriptions`, when subscriptions are successfully created on the new partitions, change the log printing content from "Successfully created new partitions" to "Successfully created subscriptions on new partitions".
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/Pomelongan/pulsar/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18024: [fix][broker]update the log print content of createSubscriptions
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18024: [fix][broker]update the log print content of createSubscriptions
URL: https://github.com/apache/pulsar/pull/18024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18024: [fix][broker] Update the log print content of createSubscriptions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18024:
URL: https://github.com/apache/pulsar/pull/18024#issuecomment-1277315655
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18024?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@92b4708`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18024 +/- ##
=========================================
Coverage ? 70.88%
Complexity ? 438
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1592
Misses ? 481
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.88% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18024: [fix][broker] Update the log print content of createSubscriptions
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18024:
URL: https://github.com/apache/pulsar/pull/18024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org