You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/03 15:29:45 UTC
[GitHub] [incubator-nuttx] lucasssvaz opened a new pull request, #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
lucasssvaz opened a new pull request, #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520
## Summary
This PR intends to reduce the repetition of Linker-related files among boards based on ESP32-S2 by moving the generic ones to a common folder. It is based on #7500.
## Impact
No relevant impact expected to neither existing boards on the repository, nor to custom boards.
Custom boards, in fact, may benefit from this change and avoid the aforementioned duplication of linker script files.
## Testing
CI build pass.
`esp32s2-saola-1:nsh` booting fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520#discussion_r1013128770
##########
boards/xtensa/esp32s2/common/scripts/.gitignore:
##########
@@ -0,0 +1 @@
+/*.ld.tmp
Review Comment:
```suggestion
/*.ld.tmp
```
Missing newline at the end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] lucasssvaz commented on a diff in pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520#discussion_r1013200392
##########
boards/xtensa/esp32s2/common/scripts/esp32s2_sections.ld:
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * boards/xtensa/esp32s2/esp32s2-saola-1/scripts/esp32s2_flash.ld
+ * boards/xtensa/esp32s2/common/scripts/esp32s2_sections.ld
Review Comment:
Fixed.
##########
boards/xtensa/esp32s2/common/scripts/.gitignore:
##########
@@ -0,0 +1 @@
+/*.ld.tmp
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520#discussion_r1013409295
##########
boards/xtensa/esp32s2/esp32s2-saola-1/scripts/.gitignore:
##########
@@ -1 +0,0 @@
-/esp32s2_out.ld
Review Comment:
why not removing `.gitignore` at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520#discussion_r1013133175
##########
boards/xtensa/esp32s2/common/scripts/esp32s2_sections.ld:
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * boards/xtensa/esp32s2/esp32s2-saola-1/scripts/esp32s2_flash.ld
+ * boards/xtensa/esp32s2/common/scripts/esp32s2_sections.ld
Review Comment:
Since the `esp32s2_iram.ld` and `esp32s2_flash.ld` scripts have been merged into one, the following adjustments are now required:
- `.flash.rodata` output section shall be allocated into `default_rodata_seg`.
- `.flash.text` output section shall be allocated into `default_code_seg`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] lucasssvaz commented on a diff in pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520#discussion_r1013440921
##########
boards/xtensa/esp32s2/esp32s2-saola-1/scripts/.gitignore:
##########
@@ -1 +0,0 @@
-/esp32s2_out.ld
Review Comment:
It was removed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7520: xtensa/esp32s2: Move linker scripts to folder common to all boards
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7520:
URL: https://github.com/apache/incubator-nuttx/pull/7520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org