You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/08 13:05:53 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15963: [fix][broker] KeyShared stickyHashRange subscription: Fix not be able to receive a message when send a can‘t match consumer message

Technoboy- commented on code in PR #15963:
URL: https://github.com/apache/pulsar/pull/15963#discussion_r892337710


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java:
##########
@@ -363,6 +363,51 @@ public void testNonKeySendAndReceiveWithHashRangeExclusiveStickyKeyConsumerSelec
         receiveAndCheck(checkList);
     }
 
+    @Test(dataProvider = "batch")
+    public void testKeySendAndReceiveWithHashRangeExclusiveStickyKeyUnMatchConsumer(boolean enableBatch)
+            throws PulsarClientException, InterruptedException {
+        this.conf.setSubscriptionKeySharedEnable(true);

Review Comment:
   Seems this config not work.



##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java:
##########
@@ -363,6 +363,51 @@ public void testNonKeySendAndReceiveWithHashRangeExclusiveStickyKeyConsumerSelec
         receiveAndCheck(checkList);
     }
 
+    @Test(dataProvider = "batch")
+    public void testKeySendAndReceiveWithHashRangeExclusiveStickyKeyUnMatchConsumer(boolean enableBatch)
+            throws PulsarClientException, InterruptedException {
+        this.conf.setSubscriptionKeySharedEnable(true);

Review Comment:
   Seems this config not work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org